[jira] [Commented] (YARN-3390) RMTimelineCollector should have the context info of each app

["Naganarasimha G R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393095#comment-14393095 ] 

Naganarasimha G R commented on YARN-3390:
-----------------------------------------

Hi [~zjshen], [~djp] & [~sjlee0]
{{TimelineCollector.getTimelineEntityContext()}} interface will not be suitable for the RMTimelineCollector as it will be posting/putting entities for multiple apps, appattempts and containers. Hence was initially planning to modify this method to take a {{TimelineEntity.Identifier}} as a parameter and @ RMTimelineCollector planning to hold a  map of {{TimelineEntity.Identifier to AppId}} and another Map to hold {{AppId to TimelineEntityContext}} (required as context is created per app when appCreatedEvent occurs). 
But one more conflict which i can see is AppLevelTimelineCollector is specific for a app, so invoking {{getTimelineEntityContext}} in {{getTimelineEntityContext(TimelineEntities ,Ugi)}} is fine because all the entities which are posted can be assumed to have same context as they belong to a single app but in a general case (like RMTimelineCollector) its not guaranteed that all TimelineEntities belong to same app(i.e. TimelineEntities might have diff context). so would it be better to change the interface of {{TimelineCollector.putEntities)}} to accept the {{TimelineEntityContext}} as parameter and remove {{TimelineCollector.getTimelineEntityContext()}} method from interface ? please share your opinion...

> RMTimelineCollector should have the context info of each app
> ------------------------------------------------------------
>
>                 Key: YARN-3390
>                 URL: https://issues.apache.org/jira/browse/YARN-3390
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>
> RMTimelineCollector should have the context info of each app whose entity  has been put



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)