You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HeimingZ (via GitHub)" <gi...@apache.org> on 2023/06/02 07:27:19 UTC
[GitHub] [iotdb] HeimingZ opened a new pull request, #10035: Get canonical path when using IOTDB_DATA_HOME and IOTDB_HOME
HeimingZ opened a new pull request, #10035:
URL: https://github.com/apache/iotdb/pull/10035
Current addDataHomeDir method in the IoTDBConfig cannot fulfill its responsibilities. We should get canonical path when using IOTDB_DATA_HOME and IOTDB_HOME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] lancelly commented on a diff in pull request #10035: Get canonical path when using IOTDB_DATA_HOME and IOTDB_HOME
Posted by "lancelly (via GitHub)" <gi...@apache.org>.
lancelly commented on code in PR #10035:
URL: https://github.com/apache/iotdb/pull/10035#discussion_r1214144924
##########
node-commons/src/main/java/org/apache/iotdb/commons/utils/PathUtils.java:
##########
@@ -202,4 +203,16 @@ private static boolean checkBackQuotes(String src) {
}
return src.length() == (src.replace("``", "").length() + num);
}
+
+ /** Add a prefix to a relative path file */
+ public static String addPrefix2FilePath(String prefix, String file) {
Review Comment:
Perhaps we should put this method in FileUtils. PathUtils is for PartialPath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #10035: Get canonical path when using IOTDB_DATA_HOME and IOTDB_HOME
Posted by "xingtanzjr (via GitHub)" <gi...@apache.org>.
xingtanzjr merged PR #10035:
URL: https://github.com/apache/iotdb/pull/10035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HeimingZ commented on a diff in pull request #10035: Get canonical path when using IOTDB_DATA_HOME and IOTDB_HOME
Posted by "HeimingZ (via GitHub)" <gi...@apache.org>.
HeimingZ commented on code in PR #10035:
URL: https://github.com/apache/iotdb/pull/10035#discussion_r1214160917
##########
node-commons/src/main/java/org/apache/iotdb/commons/utils/PathUtils.java:
##########
@@ -202,4 +203,16 @@ private static boolean checkBackQuotes(String src) {
}
return src.length() == (src.replace("``", "").length() + num);
}
+
+ /** Add a prefix to a relative path file */
+ public static String addPrefix2FilePath(String prefix, String file) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org