You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/02/11 20:19:39 UTC
[GitHub] [hop] nadment opened a new pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
nadment opened a new pull request #1355:
URL: https://github.com/apache/hop/pull/1355
Reacts like a native dialog box, if a folder is selected, and you select the OK button, you navigate to the folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1355:
URL: https://github.com/apache/hop/pull/1355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] nadment commented on pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #1355:
URL: https://github.com/apache/hop/pull/1355#issuecomment-1038201232
In this case, when you can select a file OR a folder, you have to select a file in the folder and replace its name with a wildcard. At the moment we have an error when we select a folder and then click the open button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1355:
URL: https://github.com/apache/hop/pull/1355#issuecomment-1038075181
Not sure this is the response we want, there are plenty of cases for example when using a text file input transform that you want it to return the path to the folder and then use a wildcard to filter the files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1355:
URL: https://github.com/apache/hop/pull/1355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] nadment commented on pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #1355:
URL: https://github.com/apache/hop/pull/1355#issuecomment-1038201232
In this case, when you can select a file OR a folder, you have to select a file in the folder and replace its name with a wildcard. At the moment we have an error when we select a folder and then click the open button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1355:
URL: https://github.com/apache/hop/pull/1355#issuecomment-1038448279
you are right, no error is better than what we now have. merging... we can add folder select functionality later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1355: Hop-3749 HopVfsFileDialog browsing for files and selecting a folder
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1355:
URL: https://github.com/apache/hop/pull/1355#issuecomment-1038075181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org