You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/20 11:10:34 UTC

[GitHub] mxm commented on issue #7762: [FLINK-11146] Remove invalid codes in ClusterClient

mxm commented on issue #7762: [FLINK-11146] Remove invalid codes in ClusterClient
URL: https://github.com/apache/flink/pull/7762#issuecomment-465530727
 
 
   >    1. There is still one method depend on legacy mode but I am not sure if we can directly remove it or should be there a port. It is `endSession(JobID jobID)`. I can see now the message(`JobManagerMessages.RemoveCachedJob`) it sends is what no one processes and thus guess that we can directly remove this method as well as its use point in `ContextEnvironment` and `RemoteExecutor`. But I think it is necessary to involve a committer who know how this logic works to confirm that we can do that.
   
   That batch-related feature was never fully implemented. Seems fair to remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services