You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2022/01/06 20:24:33 UTC
[maven] 01/01: [MNG-7263] improve AbstractLifecycleProvider
This is an automated email from the ASF dual-hosted git repository.
hboutemy pushed a commit to branch MNG-7263
in repository https://gitbox.apache.org/repos/asf/maven.git
commit 363a5286d65efc9b354a27e9ad0b1550ba31715d
Author: Hervé Boutemy <hb...@apache.org>
AuthorDate: Thu Jan 6 21:21:34 2022 +0100
[MNG-7263] improve AbstractLifecycleProvider
---
.../lifecycle/providers/AbstractLifecycleProvider.java | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java b/maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java
index eb80a58..ca79d2e 100644
--- a/maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java
+++ b/maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java
@@ -41,11 +41,18 @@ public abstract class AbstractLifecycleProvider
HashMap<String, LifecyclePhase> defaultBindings = null;
if ( pluginBindings != null )
{
- int len = pluginBindings.length;
+ final int len = pluginBindings.length;
+
+ if ( len < 1 || len % 2 != 0 )
+ {
+ throw new IllegalArgumentException( "Plugin bindings must have more than 0, even count of elements" );
+ }
+
defaultBindings = new HashMap<>();
- for ( int i = 0; i < len; i++ )
+
+ for ( int i = 0; i < len; i += 2 )
{
- defaultBindings.put( pluginBindings[i++], new LifecyclePhase( pluginBindings[i] ) );
+ defaultBindings.put( pluginBindings[i], new LifecyclePhase( pluginBindings[i + 1] ) );
}
}