You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org> on 2026/05/14 09:00:10 UTC

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Mihaly Szjatinya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24302


Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................

IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky

In recent IMPALA-14801 expected query times were reduced, but apparently
overly so. Doubling all times proportionally.

Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
---
M tests/custom_cluster/test_topic_update_frequency.py
1 file changed, 12 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/24302/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org>.
Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@10
PS2, Line 10: Doubling all times proportionally.
> So the test failed with:
The sleep times are for the slow blocking queries. 

The key is the change in expected time 'fast_query_timeout_ms=2000' for '__run_topic_update_test_inner' method. Everything else is just to preserve the original proportions. 

In IMPALA-14801, for non-iceberg tests it was merely bugfixing/refactoring. Together with new variants and the new Iceberg tests the overall time has largely grown up. That's why I reduced all times by the factor of (arbitrary) 5. But looks like it needs to be rolled back a bit now.


http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@11
PS2, Line 11: 
> Please mention how did you reproduce the issue, e.g. "Running the test 100 
I'm not able to reproduce it locally, even after 100 tries. 

Btw, before IMPALA-14801 there was a comment in code, stating that these fast queries take a couple of seconds, but on my environment it's only some milliseconds. I thought the comment is incorrect and changed it, but maybe I'm missing something.

Do you have an idea what could be an environment difference?



-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 14:13:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 14:40:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 2:

(2 comments)

Thanks for working on the fix!

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@10
PS2, Line 10: Doubling all times proportionally.
So the test failed with:

 select * from functional.tinytable limit 1 did not complete within 1000 msec

Could you please explain in more detail why the increased sleep times will help the query to complete in time.


http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@11
PS2, Line 11: 
Please mention how did you reproduce the issue, e.g. "Running the test 100 times, earlier it failed N/100, now it fails 0/100".



-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 09:22:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 19:04:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22423/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 09:24:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

LGTM!

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@10
PS2, Line 10: Doubling all times proportionally.
> The sleep times are for the slow blocking queries. 
Thanks for the explanation!


http://gerrit.cloudera.org:8080/#/c/24302/2//COMMIT_MSG@11
PS2, Line 11: 
> I'm not able to reproduce it locally, even after 100 tries. 
Seems like these tests are running serially, so without query profiles I don't have a good explanation for such large differences. Maybe in the logs there are some clues about it.



-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 14:39:58 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13490/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 14:40:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14987: test topic updates unblock legacy catalog is flaky

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24302 )

Change subject: IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky
......................................................................

IMPALA-14987: test_topic_updates_unblock_legacy_catalog is flaky

In recent IMPALA-14801 expected query times were reduced, but apparently
overly so. Doubling all times proportionally.

Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Reviewed-on: http://gerrit.cloudera.org:8080/24302
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_topic_update_frequency.py
1 file changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c1f01de08d4d17972579ead96499adcdb9eb038
Gerrit-Change-Number: 24302
Gerrit-PatchSet: 4
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>