You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "junwen yang (Jira)" <ji...@apache.org> on 2020/12/02 05:17:00 UTC

[jira] [Created] (MESOS-10202) Protobuf Mesage Incompatibility Detector

junwen yang created MESOS-10202:
-----------------------------------

             Summary: Protobuf Mesage Incompatibility Detector
                 Key: MESOS-10202
                 URL: https://issues.apache.org/jira/browse/MESOS-10202
             Project: Mesos
          Issue Type: Improvement
            Reporter: junwen yang
         Attachments: powerstation-fse2018.pdf

Regarding the issue [MESOS-3989|https://issues.apache.org/jira/browse/MESOS-3989] caused by the incompatibility of protobuf message, we have created a static checker which keeps track of the proto file change, and detect potential incompatibility:
 # Add/delete required field, which is the case reported in HBASE-25238.
 # The tag number of a field has been changed, as described in HDFS-9788. Also, the [protobuf guidelines |https://developers.google.com/protocol-buffers/docs/proto]suggests _each field in the message definition has a *unique number*. These numbers are used to identify your fields in the [message binary format|https://developers.google.com/protocol-buffers/docs/encoding], and should not be changed once your message type is in use_. 
 # A  required field has been changed to optional, or an optional field has been changed to required. According to the guidelines in [protobuf official website|https://developers.google.com/protocol-buffers/docs/proto], _*Required Is Forever* You should be very careful about marking fields as {{required}}. If at some point you wish to stop writing or sending a required field, it will be problematic to change the field to an optional field - old readers will consider messages without this field to be incomplete and may reject or drop them unintentionally. You should consider writing application-specific custom validation routines for your buffers instead._

We have applied our checker on the frequently maintained MESOS versions: 1.4.3, 1.5.2, 1.7.0, 1.7.3, 1.9.0, 1.10.0, 1.11.0, we found 20 problems in total as attached. 

The results reported by our checker got confirmation from developers in HBASE, which can be found here HBASE-25340. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)