You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/24 21:04:32 UTC
[GitHub] [maven] kwin commented on a change in pull request #345: MNG-5583 new feature PKI authentication to nexus repositories
kwin commented on a change in pull request #345:
URL: https://github.com/apache/maven/pull/345#discussion_r445169403
##########
File path: maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java
##########
@@ -125,5 +126,301 @@ public void setPrivateKey( final String privateKey )
{
this.privateKey = privateKey;
}
+
+
+ /**
+ *
+ *
+ * The path to the trust store. If not defined, the JRE's cacert store is
+ * used.
+ *
+ *
+ */
+ private String trustStore;
+
+ /**
+ *
+ *
+ * The password to the trust store.
+ *
+ *
+ */
+ private String trustStorePassword;
+
+ /**
+ *
+ *
+ * The type of trust store, default is JKS
Review comment:
Since Java 9 it is no longer JKS by default: http://openjdk.java.net/jeps/229
##########
File path: maven-settings/src/main/mdo/settings.mdo
##########
@@ -580,6 +580,92 @@
]]>
</description>
</field>
+
+
+ <field>
+ <name>trustStore</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The path to the trust store. If not defined, the JRE's cacert store is used.
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>trustStorePassword</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The password to the trust store.
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>trustStoreType</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The type of trust store, default is JKS
Review comment:
fix default
##########
File path: maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java
##########
@@ -125,5 +126,301 @@ public void setPrivateKey( final String privateKey )
{
this.privateKey = privateKey;
}
+
+
+ /**
+ *
+ *
+ * The path to the trust store. If not defined, the JRE's cacert store is
+ * used.
+ *
+ *
+ */
+ private String trustStore;
+
+ /**
+ *
+ *
+ * The password to the trust store.
+ *
+ *
+ */
+ private String trustStorePassword;
+
+ /**
+ *
+ *
+ * The type of trust store, default is JKS
+ *
+ * .
+ */
+ private String trustStoreType;
+
+ /**
+ *
+ *
+ * The path to the keystore used for authentication purposes, or null
+ *
+ * .
+ */
+ private String keyStore;
+
+ /**
+ *
+ *
+ * Keystore password, can be null
+ *
+ * .
+ */
+ private String keyStorePassword;
+
+ /**
+ *
+ *
+ * Keystore if the key store has multiple key pairs, this can be used to
+ * explicitly select a specific certificate via it's alias. If null, the
+ * most appropriate certificate is automatically selected by the SSL Factory
+ *
+ * .
+ */
+ private String keyAlias;
+
+ /**
+ *
+ *
+ * The password to unlock the key, can be null
+ *
+ * .
+ */
+ private String keyPassword;
+
+ /**
+ *
+ *
+ * The key store type, defaults to JKS
+ *
Review comment:
Same as above. Changed in Java 9
##########
File path: maven-settings/src/main/mdo/settings.mdo
##########
@@ -580,6 +580,92 @@
]]>
</description>
</field>
+
+
+ <field>
+ <name>trustStore</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The path to the trust store. If not defined, the JRE's cacert store is used.
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>trustStorePassword</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The password to the trust store.
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>trustStoreType</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The type of trust store, default is JKS
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>keyStore</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The path to the keystore used for authentication purposes, or null
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+
+ <field>
+ <name>keyStorePassword</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ Keystore password, can be null
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>keyAlias</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ Keystore if the key store has multiple key pairs, this can be used to explicitly
+ select a specific certificate via it's alias. If null, the most appropriate
+ certificate is automatically selected by the SSL Factory
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>keyPassword</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The password to unlock the key, can be null
+ ]]>
+ </description>
+ <type>String</type>
+ </field>
+ <field>
+ <name>keyStoreType</name>
+ <version>1.0.0+</version>
+ <description>
+ <![CDATA[
+ The key store type, defaults to JKS
Review comment:
Default changed in Java 9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org