You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2013/12/21 15:24:52 UTC

svn commit: r1552908 - /ofbiz/trunk/applications/product/widget/facility/InventoryForms.xml

Author: jleroux
Date: Sat Dec 21 14:24:51 2013
New Revision: 1552908

URL: http://svn.apache.org/r1552908
Log:
Fix a bug reported by Chris Snow at https://issues.apache.org/jira/browse/OFBIZ-2847 for "Create New Inventory Item - user entered Inventory Item Id overwritten with system generated one"

It does not make sense to allow entering an inventoryItemId. It is and must be generated by the system anyway (to prevent collisions)

Modified:
    ofbiz/trunk/applications/product/widget/facility/InventoryForms.xml

Modified: ofbiz/trunk/applications/product/widget/facility/InventoryForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/facility/InventoryForms.xml?rev=1552908&r1=1552907&r2=1552908&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/widget/facility/InventoryForms.xml (original)
+++ ofbiz/trunk/applications/product/widget/facility/InventoryForms.xml Sat Dec 21 14:24:51 2013
@@ -34,15 +34,14 @@ under the License.
             </entity-one>
         </actions>
         <alt-target use-when="inventoryItemId==null" target="CreateInventoryItem"/>
-        <auto-fields-service service-name="updateInventoryItem" map-name="inventoryItem"/>
+        <auto-fields-service service-name="updateInventoryItem" map-name="inventoryItem"/>        
 
         <!-- ignored fields -->
         <field name="oldAvailableToPromise"><ignored/></field>
         <field name="oldQuantityOnHand"><ignored/></field>
-
+        
         <!-- custom formatted fields -->
-        <field use-when="inventoryItem!=null" name="inventoryItemId" tooltip="${uiLabelMap.ProductNotModificationRecrationInventoryItem}"><display/></field>
-        <field use-when="inventoryItem==null" name="inventoryItemId"><text/></field>
+        <field name="inventoryItemId" tooltip="${uiLabelMap.ProductNotModificationRecrationInventoryItem}"><display/></field>
         <field name="inventoryItemTypeId" title="${uiLabelMap.ProductInventoryItemTypeId}">
             <drop-down allow-empty="false">
                 <entity-options entity-name="InventoryItemType" description="${description}" key-field-name="inventoryItemTypeId"/>