[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #297: [YUNIKORN-791] Allow to register nodes with infinite resources

[GitBox <gi...@apache.org>]

wilfred-s commented on pull request #297:
URL: https://github.com/apache/incubator-yunikorn-core/pull/297#issuecomment-897269967


   I have a couple of remarks:
   * We must not allow more than one node to be registered if we have a node with infinite resources. Node sorting would become a problem. This needs to be enforced in the code.
   * I doubt that we can have reservations turned on. The whole node would be reserved and thus things would stop. Reservations would need to be turned off completely.
   
   In the solution chosen you special case each action. This bypasses updating allocated resources completely. That means lots of small changes everywhere. Resource calculations should all be nil safe (if not that is a bug on that calculation). Can we not set the `availableResource` to nil and leave the normal processing flow unchanged? That would remove a lot of the maintenance burden for later and the node will still show "normal" values when displayed in the web UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org