You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/02/22 09:13:21 UTC

[GitHub] zeppelin pull request #1794: [WIP][MINOR][ZEPPELIN-804] Remove static method...

GitHub user jongyoul reopened a pull request:

    https://github.com/apache/zeppelin/pull/1794

    [WIP][MINOR][ZEPPELIN-804] Remove static method for static initialization

    ### What is this PR for?
    This is one of steps of ZEPPELIN-804 to change the way of registration of interpreter. This PR removes some static method and replace those code to use new mechanism
    
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [ ] - Remove `public static void register(...)`
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-804
    
    ### How should this be tested?
    N/A
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin minor/remove-interpreter-register

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1794.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1794
    
----
commit 71a2377cf2208137e55b3efbf26a12390d55a777
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2016-12-22T18:05:42Z

    Removed `public static void register(String name, String className)`

commit 67321c681f79c5b6052e3c62ce162ae5d5b5617f
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2016-12-22T18:40:10Z

    Remove commented code

commit 875e869015e7a1415d495f46c3e98faf1d83ad62
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2016-12-22T18:54:51Z

    Removed `register(String name, String group, String className, boolean defaultInterpreter)`
    Removed `register(String name, String group, String className)`

commit 06147a7930c19b50d0c663f8fe40cac43f17eaf3
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2016-12-24T18:35:33Z

    Fixed interpreterOption to pass some tests

commit c505a78d5d724b466fe1e6f9652335470ecc5c5d
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-01-20T16:22:00Z

    Removed static logic from DevInterpreter in helium-dev

commit eb2c828f4469f6f87c6c56f184db389ebf573d90
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-01-23T06:33:37Z

    Removed static initialization code for all mock interpreters

commit e9dcf3ab8916e8174218e906d2256447782d8400
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-01-23T06:34:05Z

    Marked as deprecated in all Interpreter.register methods

commit cba3e02377280ed1cb727f2218296e3f1dbfd490
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-01-23T11:20:00Z

    Fixed test cases

commit d0ea3b3b24b107e9122fcb3de51ed486956b2244
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-01-24T05:39:09Z

    Fixed Test cases

commit 53abb6a0556e811defa8911218c2556da593ee9c
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-02-22T07:04:33Z

    Fixed some tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---