You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/02/03 06:02:16 UTC

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #183: Support the Wireshark plugin for more Wireshark distributions

BewareMyPower commented on code in PR #183:
URL: https://github.com/apache/pulsar-client-cpp/pull/183#discussion_r1095385665


##########
wireshark/CMakeLists.txt:
##########
@@ -17,67 +17,46 @@
 # under the License.
 #
 
-set(CMAKE_CXX_FLAGS "-O3 -g ${CMAKE_CXX_FLAGS}")
+cmake_minimum_required(VERSION 3.7)
+project(pulsar-cpp-wireshark)
 
-MESSAGE(STATUS "Use WIRESHARK_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
+set(CMAKE_CXX_STANDARD 11)
 

Review Comment:
   Addressed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org