You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/08 18:40:57 UTC

[GitHub] [airflow] codecov-io edited a comment on issue #6386: [AIRFLOW-5716][part of AIRFLOW-5697] Simplify DataflowJobsController logic

codecov-io edited a comment on issue #6386: [AIRFLOW-5716][part of AIRFLOW-5697] Simplify DataflowJobsController logic
URL: https://github.com/apache/airflow/pull/6386#issuecomment-546581408
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6386?src=pr&el=h1) Report
   > Merging [#6386](https://codecov.io/gh/apache/airflow/pull/6386?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/33ddcd9ef7b0c7c1e888e4aad93a641022571a9f?src=pr&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `85.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6386/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6386?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6386      +/-   ##
   ==========================================
   - Coverage    83.8%   83.74%   -0.07%     
   ==========================================
     Files         635      635              
     Lines       36750    36743       -7     
   ==========================================
   - Hits        30800    30769      -31     
   - Misses       5950     5974      +24
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6386?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `91.59% <85.29%> (-0.65%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `33.33% <0%> (-41.67%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `70.14% <0%> (-28.36%)` | :arrow_down: |
   | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.28% <0%> (-0.51%)` | :arrow_down: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `58.48% <0%> (+0.32%)` | :arrow_up: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.52% <0%> (+0.84%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `65% <0%> (+1.11%)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6386/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6386?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6386?src=pr&el=footer). Last update [33ddcd9...679ae91](https://codecov.io/gh/apache/airflow/pull/6386?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services