You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2009/08/21 00:44:14 UTC
[jira] Created: (LUCENE-1833) When we move to java 1.5 in 3.0 we
should replace all Interger, Long, etc construction with .valueOf
When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
----------------------------------------------------------------------------------------------------
Key: LUCENE-1833
URL: https://issues.apache.org/jira/browse/LUCENE-1833
Project: Lucene - Java
Issue Type: Improvement
Reporter: Mark Miller
Priority: Trivial
Fix For: 3.0
-128 to 128 are guaranteed to be cached and using valueOf in that case is 3.5 times faster than using contructor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1833) When we move to java 1.5 in 3.0 we
should replace all Interger, Long, etc construction with .valueOf
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761752#action_12761752 ]
Mark Miller commented on LUCENE-1833:
-------------------------------------
bq. I hope, nobody has problems with merging caused by this!
Pfff - so many good merge tools out there today, lets not let that get in the way of this sweet rapid movement to java 1.5!
If anyone is annoyed, I'd be happy to merge any patch for them.
> When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
> ----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1833
> URL: https://issues.apache.org/jira/browse/LUCENE-1833
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: LUCENE-1833.patch
>
>
> -128 to 128 are guaranteed to be cached and using valueOf in that case is 3.5 times faster than using contructor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1833) When we move to java 1.5 in 3.0 we
should replace all Interger, Long, etc construction with .valueOf
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1833:
----------------------------------
Attachment: LUCENE-1833.patch
This patch changes all "new Number(" code parts with "Number.valueOf(" (changed using find/sed). All tests pass.
I want to commit this as soon as possible, because it affects lots of files and I do not want to get this patch outdated. The StringBuffer from previous comment is in another issue.
> When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
> ----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1833
> URL: https://issues.apache.org/jira/browse/LUCENE-1833
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: LUCENE-1833.patch
>
>
> -128 to 128 are guaranteed to be cached and using valueOf in that case is 3.5 times faster than using contructor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1833) When we move to java 1.5 in 3.0 we
should replace all Interger, Long, etc construction with .valueOf
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761756#action_12761756 ]
Robert Muir commented on LUCENE-1833:
-------------------------------------
Uwe, I agree with what Mark said.
my previous comment on LUCENE-1936 really was just me wanting to stay out of your way, not the other way around :)
> When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
> ----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1833
> URL: https://issues.apache.org/jira/browse/LUCENE-1833
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: LUCENE-1833.patch
>
>
> -128 to 128 are guaranteed to be cached and using valueOf in that case is 3.5 times faster than using contructor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1833) When we move to java 1.5 in 3.0 we
should replace all Interger, Long, etc construction with .valueOf
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-1833.
-----------------------------------
Resolution: Fixed
Committed revision: 821186
I hope, nobody has problems with merging caused by this!
> When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
> ----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1833
> URL: https://issues.apache.org/jira/browse/LUCENE-1833
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.0
>
> Attachments: LUCENE-1833.patch
>
>
> -128 to 128 are guaranteed to be cached and using valueOf in that case is 3.5 times faster than using contructor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1833) When we move to java 1.5 in 3.0 we
should replace all Interger, Long, etc construction with .valueOf
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reassigned LUCENE-1833:
-------------------------------------
Assignee: Uwe Schindler
> When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
> ----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1833
> URL: https://issues.apache.org/jira/browse/LUCENE-1833
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.0
>
>
> -128 to 128 are guaranteed to be cached and using valueOf in that case is 3.5 times faster than using contructor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1833) When we move to java 1.5 in 3.0 we
should replace all Interger, Long, etc construction with .valueOf
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745708#action_12745708 ]
Uwe Schindler commented on LUCENE-1833:
---------------------------------------
...and also StringBuffers!
> When we move to java 1.5 in 3.0 we should replace all Interger, Long, etc construction with .valueOf
> ----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1833
> URL: https://issues.apache.org/jira/browse/LUCENE-1833
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Mark Miller
> Priority: Trivial
> Fix For: 3.0
>
>
> -128 to 128 are guaranteed to be cached and using valueOf in that case is 3.5 times faster than using contructor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org