You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2013/08/13 10:41:46 UTC
[DISCUSS] git commit messages
LS,
I see a lot of commits with only ticket numbers as commit messages.
This is not very descriptive and makes me suspicious of what I am
pulling in. Can people please append a more descriptive message to the
ticket number? Or am I the only one disturbed by this?
regards,
Daan
RE: [DISCUSS] git commit messages
Posted by Rajesh Battala <ra...@citrix.com>.
+1
-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
Sent: Tuesday, August 13, 2013 2:12 PM
To: dev
Subject: [DISCUSS] git commit messages
LS,
I see a lot of commits with only ticket numbers as commit messages.
This is not very descriptive and makes me suspicious of what I am pulling in. Can people please append a more descriptive message to the ticket number? Or am I the only one disturbed by this?
regards,
Daan
RE: [DISCUSS] git commit messages
Posted by "Musayev, Ilya" <im...@webmd.net>.
+1, this should be really easy to add and helps tremendously and troubleshooting!
> -----Original Message-----
> From: Koushik Das [mailto:koushik.das@citrix.com]
> Sent: Friday, August 16, 2013 1:48 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [DISCUSS] git commit messages
>
> Agree. The message should indicate the root cause of the problem and the
> solution.
>
> -Koushik
>
> > -----Original Message-----
> > From: Alex Huang [mailto:Alex.Huang@citrix.com]
> > Sent: Friday, August 16, 2013 2:58 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [DISCUSS] git commit messages
> >
> > +1
> >
> > --Alex
> >
> > > -----Original Message-----
> > > From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
> > > Sent: Thursday, August 15, 2013 11:58 AM
> > > To: dev
> > > Subject: Re: [DISCUSS] git commit messages
> > >
> > > ok,
> > >
> > > I saw some violation passing by containing only
> > > CLOUDSTACK-<ticket-number> as message.
> > >
> > > I am probably not the best citizen in the world but this freaks me,
> > > so this is a reminder to everyone to add a message (and for
> > > committers to refuse submissions without it?)
> > >
> > > thanks,
> > > Daan
> > >
> > > On Thu, Aug 15, 2013 at 8:49 PM, Animesh Chaturvedi
> > > <an...@citrix.com> wrote:
> > > > Yes the commit message should have a brief summary of the change
> > > >
> > > >> -----Original Message-----
> > > >> From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
> > > >> Sent: Thursday, August 15, 2013 11:36 AM
> > > >> To: dev@cloudstack.apache.org
> > > >> Subject: Re: [DISCUSS] git commit messages
> > > >>
> > > >> Not good. Especially since it is documented
> > > >> https://cwiki.apache.org/confluence/x/4wnVAQ
> > > >>
> > > >> On 8/13/13 1:41 AM, "Daan Hoogland" <da...@gmail.com>
> > > wrote:
> > > >>
> > > >> >LS,
> > > >> >
> > > >> >I see a lot of commits with only ticket numbers as commit messages.
> > > >> >This is not very descriptive and makes me suspicious of what I
> > > >> >am pulling in. Can people please append a more descriptive
> > > >> >message to the ticket number? Or am I the only one disturbed by
> this?
> > > >> >
> > > >> >regards,
> > > >> >Daan
> > > >
RE: [DISCUSS] git commit messages
Posted by Koushik Das <ko...@citrix.com>.
Agree. The message should indicate the root cause of the problem and the solution.
-Koushik
> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Friday, August 16, 2013 2:58 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [DISCUSS] git commit messages
>
> +1
>
> --Alex
>
> > -----Original Message-----
> > From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
> > Sent: Thursday, August 15, 2013 11:58 AM
> > To: dev
> > Subject: Re: [DISCUSS] git commit messages
> >
> > ok,
> >
> > I saw some violation passing by containing only
> > CLOUDSTACK-<ticket-number> as message.
> >
> > I am probably not the best citizen in the world but this freaks me, so
> > this is a reminder to everyone to add a message (and for committers to
> > refuse submissions without it?)
> >
> > thanks,
> > Daan
> >
> > On Thu, Aug 15, 2013 at 8:49 PM, Animesh Chaturvedi
> > <an...@citrix.com> wrote:
> > > Yes the commit message should have a brief summary of the change
> > >
> > >> -----Original Message-----
> > >> From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
> > >> Sent: Thursday, August 15, 2013 11:36 AM
> > >> To: dev@cloudstack.apache.org
> > >> Subject: Re: [DISCUSS] git commit messages
> > >>
> > >> Not good. Especially since it is documented
> > >> https://cwiki.apache.org/confluence/x/4wnVAQ
> > >>
> > >> On 8/13/13 1:41 AM, "Daan Hoogland" <da...@gmail.com>
> > wrote:
> > >>
> > >> >LS,
> > >> >
> > >> >I see a lot of commits with only ticket numbers as commit messages.
> > >> >This is not very descriptive and makes me suspicious of what I am
> > >> >pulling in. Can people please append a more descriptive message to
> > >> >the ticket number? Or am I the only one disturbed by this?
> > >> >
> > >> >regards,
> > >> >Daan
> > >
RE: [DISCUSS] git commit messages
Posted by Alex Huang <Al...@citrix.com>.
+1
--Alex
> -----Original Message-----
> From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
> Sent: Thursday, August 15, 2013 11:58 AM
> To: dev
> Subject: Re: [DISCUSS] git commit messages
>
> ok,
>
> I saw some violation passing by containing only CLOUDSTACK-<ticket-number>
> as message.
>
> I am probably not the best citizen in the world but this freaks me, so this is a
> reminder to everyone to add a message (and for committers to refuse
> submissions without it?)
>
> thanks,
> Daan
>
> On Thu, Aug 15, 2013 at 8:49 PM, Animesh Chaturvedi
> <an...@citrix.com> wrote:
> > Yes the commit message should have a brief summary of the change
> >
> >> -----Original Message-----
> >> From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
> >> Sent: Thursday, August 15, 2013 11:36 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: [DISCUSS] git commit messages
> >>
> >> Not good. Especially since it is documented
> >> https://cwiki.apache.org/confluence/x/4wnVAQ
> >>
> >> On 8/13/13 1:41 AM, "Daan Hoogland" <da...@gmail.com>
> wrote:
> >>
> >> >LS,
> >> >
> >> >I see a lot of commits with only ticket numbers as commit messages.
> >> >This is not very descriptive and makes me suspicious of what I am
> >> >pulling in. Can people please append a more descriptive message to
> >> >the ticket number? Or am I the only one disturbed by this?
> >> >
> >> >regards,
> >> >Daan
> >
Re: [DISCUSS] git commit messages
Posted by Daan Hoogland <da...@gmail.com>.
ok,
I saw some violation passing by containing only
CLOUDSTACK-<ticket-number> as message.
I am probably not the best citizen in the world but this freaks me, so
this is a reminder to everyone to add a message (and for committers to
refuse submissions without it?)
thanks,
Daan
On Thu, Aug 15, 2013 at 8:49 PM, Animesh Chaturvedi
<an...@citrix.com> wrote:
> Yes the commit message should have a brief summary of the change
>
>> -----Original Message-----
>> From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
>> Sent: Thursday, August 15, 2013 11:36 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] git commit messages
>>
>> Not good. Especially since it is documented
>> https://cwiki.apache.org/confluence/x/4wnVAQ
>>
>> On 8/13/13 1:41 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>>
>> >LS,
>> >
>> >I see a lot of commits with only ticket numbers as commit messages.
>> >This is not very descriptive and makes me suspicious of what I am
>> >pulling in. Can people please append a more descriptive message to the
>> >ticket number? Or am I the only one disturbed by this?
>> >
>> >regards,
>> >Daan
>
RE: [DISCUSS] git commit messages
Posted by Animesh Chaturvedi <an...@citrix.com>.
Yes the commit message should have a brief summary of the change
> -----Original Message-----
> From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
> Sent: Thursday, August 15, 2013 11:36 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] git commit messages
>
> Not good. Especially since it is documented
> https://cwiki.apache.org/confluence/x/4wnVAQ
>
> On 8/13/13 1:41 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>
> >LS,
> >
> >I see a lot of commits with only ticket numbers as commit messages.
> >This is not very descriptive and makes me suspicious of what I am
> >pulling in. Can people please append a more descriptive message to the
> >ticket number? Or am I the only one disturbed by this?
> >
> >regards,
> >Daan
Re: [DISCUSS] git commit messages
Posted by Chiradeep Vittal <Ch...@citrix.com>.
Not good. Especially since it is documented
https://cwiki.apache.org/confluence/x/4wnVAQ
On 8/13/13 1:41 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>LS,
>
>I see a lot of commits with only ticket numbers as commit messages.
>This is not very descriptive and makes me suspicious of what I am
>pulling in. Can people please append a more descriptive message to the
>ticket number? Or am I the only one disturbed by this?
>
>regards,
>Daan