[incubator-inlong] branch master updated: [INLONG-3167][InLong] Remove the unused git hook and adjust the PR template (#3626)

[go...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gosonzhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-inlong.git


The following commit(s) were added to refs/heads/master by this push:
     new b2c566f9e [INLONG-3167][InLong] Remove the unused git hook and adjust the PR template (#3626)
b2c566f9e is described below

commit b2c566f9e0d95e524439b219996b7d80a51491d7
Author: ciscozhou <45...@users.noreply.github.com>
AuthorDate: Tue Apr 12 09:49:34 2022 +0800

    [INLONG-3167][InLong] Remove the unused git hook and adjust the PR template (#3626)
    
    
    Co-authored-by: dockerzhang <do...@apache.org>
---
 .github/PULL_REQUEST_TEMPLATE.md | 20 +++++++-------------
 .github/commit-msg               | 25 -------------------------
 2 files changed, 7 insertions(+), 38 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 5eefb9a31..23b385227 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,4 +1,3 @@
-
 ### Title Name: [INLONG-XYZ][component] Title of the pull request
 
 where *XYZ* should be replaced by the actual issue number.
@@ -7,7 +6,7 @@ Fixes #<xyz>
 
 ### Motivation
 
-*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
+*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
 
 ### Modifications
 
@@ -15,21 +14,16 @@ Fixes #<xyz>
 
 ### Verifying this change
 
-- [ ] Make sure that the change passes the CI checks.
-
 *(Please pick either of the following options)*
 
-This change is a trivial rework / code cleanup without any test coverage.
-
-*(or)*
-
-This change is already covered by existing tests, such as *(please describe tests)*.
+- [ ] This change is a trivial rework/code cleanup without any test coverage.
 
-*(or)*
+- [ ] This change is already covered by existing tests, such as:
+  *(please describe tests)*
 
-This change added tests and can be verified as follows:
+- [ ] This change added tests and can be verified as follows:
 
-*(example:)*
+  *(example:)*
   - *Added integration tests for end-to-end deployment with large payloads (10MB)*
   - *Extended integration test for recovery after broker failure*
 
@@ -38,4 +32,4 @@ This change added tests and can be verified as follows:
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
-  - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
+  - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
diff --git a/.github/commit-msg b/.github/commit-msg
deleted file mode 100755
index 1375f088b..000000000
--- a/.github/commit-msg
+++ /dev/null
@@ -1,25 +0,0 @@
-#!/bin/sh
-
-regular="^\[INLONG-[1-9][0-9]{3,4}\]\[(InLong|Agent|Audit|Dashboard|DataProxy|SDK|Sort|Sort-Flink|Sort-Standalone|TubeMQ|Manager|Website)\] [A-Z][a-zA-Z0-9.,-_ ]{10,100}"
-endRegular="[a-zA-Z0-9]$"
-
-error_msg="Your commit message was invalid, the format of the commit message is: [INLONG-1234][Module] Your message
-    1. [INLONG-1234] represents the issue number associated with this commit
-    2. [Module] indicates which module of Apache InLong this commit belongs to
-       Support: InLong|Agent|Audit|Dashboard|DataProxy|SDK|Sort|Sort-Flink|Sort-Standalone|TubeMQ|Manager|Website
-       If your commit involves multiple modules, please use [InLong] as the module
-    3. After a space, write your commit message, start with a capital letter and cannot end with a number, space or punctuation
-For example:
-    [INLONG-3293][Manager] Add version controller for stream source"
-
-commit_msg=$(head -n1 "$1")
-echo "$commit_msg"
-
-# shellcheck disable=SC2039
-if [[ ! $commit_msg =~ $regular || ! $commit_msg =~ $endRegular ]]; then
-    echo "\033[31mCommit failed! $error_msg\033[31m" >&2
-    exit 1
-else
-    echo "\033[32mCommit success!\033[32m"
-    exit 0
-fi
\ No newline at end of file