[GitHub] [netbeans] JaroslavTulach commented on pull request #2447: Adding debugging support to the Apache NetBeans VSCode Extension

[GitBox <gi...@apache.org>]

JaroslavTulach commented on pull request #2447:
URL: https://github.com/apache/netbeans/pull/2447#issuecomment-707430139


   > I am fine with this, I guess.
   
   Thanks. I integrate today then. There are some other changes in the queue (Martin has some and clearly #2389 contains a merge conflict) and it'd be better to have them in by feature freeze.
   
   > Some files are likely to need license headers (e.g. build-impl.xml, the build should say which ones). Otherwise, 
   
   I [have added headers](https://github.com/apache/netbeans/pull/2447/commits/56ac003b76f2c4fcc7af0dca52e1cc18c20f9413#diff-54bf8b48fd1ceeba5f9d7252feaf812a357e9ca64489296b233d7e6dd6d3ebb1R1) to files where the Travis check complained. The `build-impl.xml` is excluded from the RAT check:
   ```bash
   netbeans$ cat nbbuild/rat-exclusions.txt  | grep build-impl
   **/nbproject/build-impl.xml
   nbi/engine/nbproject/profiler-build-impl.xml
   ```
   The `build-impl.xml` in question was created by me and fully belongs to Apache.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists