You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/01/18 15:55:36 UTC
[GitHub] flink pull request #3159: [FLINK-5504] Create mesos-appmaster log file in lo...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3159
[FLINK-5504] Create mesos-appmaster log file in log directory
This PR prepends the FLINK_LOG_DIR env variable pointing to Flink's logging
directory to the logging file name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink mesosFixLoggingDir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3159
----
commit 19143548ab2a3a856d19436d6d3abed7d6700229
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-01-18T15:53:42Z
[FLINK-5504] Create mesos-appmaster log file in log directory
This PR prepends the FLINK_LOG_DIR env variable pointing to Flink's logging
directory to the logging file name.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3159: [FLINK-5504] Create mesos-appmaster log file in lo...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3159#discussion_r97308273
--- Diff: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh ---
@@ -38,9 +38,14 @@ constructAppMasterClassPath() {
echo $CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS
}
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+ FLINK_IDENT_STRING="$USER"
+fi
+
+
--- End diff --
Good catch. Will correct it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3159: [FLINK-5504] Create mesos-appmaster log file in lo...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3159#discussion_r97282251
--- Diff: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh ---
@@ -38,9 +38,14 @@ constructAppMasterClassPath() {
echo $CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS
}
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+ FLINK_IDENT_STRING="$USER"
+fi
+
+
--- End diff --
Empty line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3159: [FLINK-5504] Create mesos-appmaster log file in lo...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3159#discussion_r97308341
--- Diff: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh ---
@@ -38,9 +38,14 @@ constructAppMasterClassPath() {
echo $CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS
}
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+ FLINK_IDENT_STRING="$USER"
+fi
+
+
CC_CLASSPATH=`manglePathList $(constructAppMasterClassPath)`
-log=flink-appmaster.log
+log="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-mesos-appmaster-${HOSTNAME}.log"
--- End diff --
Thanks for clarifying this. I think in the future it could make sense to unify the different deployment scripts and fix these issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3159: [FLINK-5504] Create mesos-appmaster log file in log direc...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3159
Thanks for the review @uce. Merging this PR and #3160.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3159: [FLINK-5504] Create mesos-appmaster log file in lo...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3159#discussion_r97283093
--- Diff: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh ---
@@ -38,9 +38,14 @@ constructAppMasterClassPath() {
echo $CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS
}
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+ FLINK_IDENT_STRING="$USER"
+fi
+
+
CC_CLASSPATH=`manglePathList $(constructAppMasterClassPath)`
-log=flink-appmaster.log
+log="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-mesos-appmaster-${HOSTNAME}.log"
--- End diff --
Looks good. This is inline with the other scripts we have.
---
As a small note: If for some weird reason the `FLINK_LOG_DIR` is not correctly set, this will try to create the log file in root instead of the current working directory or something else. Having said that, not relevant for this PR as it's the same for all scripts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3159: [FLINK-5504] Create mesos-appmaster log file in lo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---