You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/01 13:51:23 UTC
[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2550: FINERACT-1721: Loan Delinquency Classification job
josehernandezfintecheandomx commented on code in PR #2550:
URL: https://github.com/apache/fineract/pull/2550#discussion_r960682132
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java:
##########
@@ -282,26 +282,28 @@ private Map<String, Object> lookUpDelinquencyRange(final Loan loan, final Delinq
Map<String, Object> changes = new HashMap<>();
if (ageDays <= 0) { // No Delinquency
- log.debug("Loan {} without delinquency range with {} days", loan.getId(), ageDays);
+ log.info("Loan {} without delinquency range with {} days", loan.getId(), ageDays);
changes = setLoanDelinquencyTag(loan, null);
} else {
// Sort the ranges based on the minAgeDays
- List<DelinquencyRange> ranges = sortDelinquencyRangesByMinAge(delinquencyBucket.getRanges());
+ final List<DelinquencyRange> ranges = sortDelinquencyRangesByMinAge(delinquencyBucket.getRanges());
- for (DelinquencyRange delinquencyRange : ranges) {
- if (delinquencyRange.getMaximumAgeDays() == null) {
+ for (final DelinquencyRange delinquencyRange : ranges) {
+ if (delinquencyRange.getMaximumAgeDays() == null) { // Last Range in the Bucket
if (delinquencyRange.getMinimumAgeDays() <= ageDays) {
- log.debug("Loan {} with delinquency range {} with {} days", loan.getId(), delinquencyRange.getClassification(),
+ log.info("Loan {} with delinquency range {} with {} days", loan.getId(), delinquencyRange.getClassification(),
ageDays);
changes = setLoanDelinquencyTag(loan, delinquencyRange.getId());
+ log.info("A Loan {} with range {}", loan.getId(), changes.get("current"));
break;
}
} else {
if (delinquencyRange.getMinimumAgeDays() <= ageDays && delinquencyRange.getMaximumAgeDays() >= ageDays) {
- log.debug("Loan {} with delinquency range {} with {} days", loan.getId(), delinquencyRange.getClassification(),
+ log.info("Loan {} with delinquency range {} with {} days", loan.getId(), delinquencyRange.getClassification(),
ageDays);
changes = setLoanDelinquencyTag(loan, delinquencyRange.getId());
+ log.info("B Loan {} with range {}", loan.getId(), changes.get("current"));
Review Comment:
REmoved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org