You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2008/08/07 19:06:01 UTC
svn commit: r683649 -
/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Author: lu4242
Date: Thu Aug 7 10:06:01 2008
New Revision: 683649
URL: http://svn.apache.org/viewvc?rev=683649&view=rev
Log:
MYFACES-1832 bad charset encoding on <f:param> tag
Modified:
myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Modified: myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java?rev=683649&r1=683648&r2=683649&view=diff
==============================================================================
--- myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java (original)
+++ myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java Thu Aug 7 10:06:01 2008
@@ -315,8 +315,13 @@
Object value = ((UIParameter) child).getValue();
//UIParameter is no ValueHolder, so no conversion possible - calling .toString on value....
- String strParamValue = value != null ? org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder.encode(value.toString(), false, false) : "";
-
+ // MYFACES-1832 bad charset encoding for f:param
+ // if HTMLEncoder.encode is called, then
+ // when is called on writer.writeAttribute, encode method
+ // is called again so we have a duplicated encode
+ // call.
+ //String strParamValue = value != null ? org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder.encode(value.toString(), false, false) : "";
+ String strParamValue = value != null ? value.toString() : "";
if (params.length() > 1) {
params.append(",");