You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/22 08:19:09 UTC

[GitHub] [flink] alpreu opened a new pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

alpreu opened a new pull request #17848:
URL: https://github.com/apache/flink/pull/17848


   ## What is the purpose of the change
   
   This change introduces a methods for test that will block until all records have been acknowledged by Elasticsearch. This fixes test instabilities that were caused by flaky timeout settings.
   
   **Only ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49 has to be reviewed, the other commits are part of https://github.com/apache/flink/pull/17538**
   
   
   ## Brief change log
   
   *(for example:)*
     - *Implement `ElasticsearchWriter#blockingFlushAllActions` method and update tests in `ElasticsearchWriterITCase` to use it instead of timeouts 
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests, such as tests in ElasticsearchWriterITCase.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] AHeise merged pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #17848:
URL: https://github.com/apache/flink/pull/17848


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17848:
URL: https://github.com/apache/flink/pull/17848#issuecomment-975246406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809",
       "triggerID" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17848:
URL: https://github.com/apache/flink/pull/17848#issuecomment-975246406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17848:
URL: https://github.com/apache/flink/pull/17848#issuecomment-975246406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809",
       "triggerID" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96fc657d42690427da941acac84f9c895262bc24",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26942",
       "triggerID" : "96fc657d42690427da941acac84f9c895262bc24",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 96fc657d42690427da941acac84f9c895262bc24 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26942) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17848:
URL: https://github.com/apache/flink/pull/17848#issuecomment-975246406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809",
       "triggerID" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96fc657d42690427da941acac84f9c895262bc24",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "96fc657d42690427da941acac84f9c895262bc24",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809) 
   * 96fc657d42690427da941acac84f9c895262bc24 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17848:
URL: https://github.com/apache/flink/pull/17848#issuecomment-975248574


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49 (Mon Nov 22 08:23:47 UTC 2021)
   
   **Warnings:**
    * **8 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17848:
URL: https://github.com/apache/flink/pull/17848#issuecomment-975246406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809",
       "triggerID" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96fc657d42690427da941acac84f9c895262bc24",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26942",
       "triggerID" : "96fc657d42690427da941acac84f9c895262bc24",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809) 
   * 96fc657d42690427da941acac84f9c895262bc24 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26942) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17848: [FLINK-24583] [connectors/elasticsearch] Improve test stability by blocking until ES has acknowledged all records

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17848:
URL: https://github.com/apache/flink/pull/17848#issuecomment-975246406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809",
       "triggerID" : "ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ab1fe6e89640d5ebc7c2f8329fdfb1ff22694b49 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26809) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org