You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Smurphy000 (via GitHub)" <gi...@apache.org> on 2023/10/16 20:33:18 UTC
[PR] Transform benchmark json to line protocol [arrow-datafusion]
Smurphy000 opened a new pull request, #7838:
URL: https://github.com/apache/arrow-datafusion/pull/7838
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6107
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- added a new `visualize` folder for attempting to visualize `history.lp` line protocol file with the use of telegraf -> influxdb -> grafance
- created a sample `history.lp` from a benchmark run to discuss syntax and fields that should be included in the final output
- modified `compare.py` to reuse existing code to convert the expected benchmark json output into line protocol file (these changes are not final)
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Testing will be conducted once some implementation details are finalized
- [ ] Testing Completed
## Are there any user-facing changes?
Changes are only to help improve efforts in tracking benchmark performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Transform benchmark json to line protocol [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7838:
URL: https://github.com/apache/datafusion/pull/7838#issuecomment-2078483406
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Transform benchmark json to line protocol [datafusion]
Posted by "Smurphy000 (via GitHub)" <gi...@apache.org>.
Smurphy000 closed pull request #7838: Transform benchmark json to line protocol
URL: https://github.com/apache/datafusion/pull/7838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org