You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "AndrewXWei (via GitHub)" <gi...@apache.org> on 2023/09/07 03:31:18 UTC
[GitHub] [spark] AndrewXWei opened a new pull request, #42843: Add ephemeral and gpu configs for spark on kubernetes
AndrewXWei opened a new pull request, #42843:
URL: https://github.com/apache/spark/pull/42843
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add the ephemeral and gpu configs for spark on kubernetes.
User can specify these configs to make their program more configable.
`
--conf spark.kubernetes.driver.ephemeralStorageGB xxx
`
`--conf spark.kubernetes.executor.gpus xxx
`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It can be used in the spark-submit command handily.
Image that you build a platform to help users to submit their data pipelines with spark, it would be very convenient to have these parameters to support user's different demands.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No. This PR does not introduce any user-facing change. It only introduces more options to users.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
We have applied these change in our internal project and it works well.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [KUBERNETES] Add ephemeral storage configs for spark on kubernetes [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42843:
URL: https://github.com/apache/spark/pull/42843#issuecomment-1868146783
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AndrewXWei commented on pull request #42843: [KUBERNETES] Add ephemeral storage configs for spark on kubernetes
Posted by "AndrewXWei (via GitHub)" <gi...@apache.org>.
AndrewXWei commented on PR #42843:
URL: https://github.com/apache/spark/pull/42843#issuecomment-1710967750
> Thank you for making a PR, @AndrewXWei .
>
> However, we recommend to use pod templates for fine tuning because we cannot have one to one mapping in `spark.kubernetes.*` configuration for all K8s features.
>
> ```
> --conf spark.kubernetes.driver.podTemplateFile=s3a://bucket/driver.yml
> --conf spark.kubernetes.executor.podTemplateFile=s3a://bucket/executor.yml
> ```
>
> Did you try to use pod template configurations?
Hi, @dongjoon-hyun Thanks for your comment.
I understand that we can not have all k8s features in spark configuration.
We are building a platform for users to submit their data pipelines easily.
Using pod template can solve the problem, and we do have one. Pod template works well for constant variables, but some variables vary from job to job (notably cpu, memory, volume, ephemeral-storage, etc.). It would requires extra effort to maintain these variable configs (both reading the code and keeping the records).
When we submit jobs to spark on kubernetes, it would be helpful to have these common variable configurations to use.
Anyway, thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [KUBERNETES] Add ephemeral storage configs for spark on kubernetes [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42843: [KUBERNETES] Add ephemeral storage configs for spark on kubernetes
URL: https://github.com/apache/spark/pull/42843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org