You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2019/05/28 09:50:58 UTC

[GitHub] [mesos] carlonelong edited a comment on issue #335: Return early in fetcher if no uris are specified.

carlonelong edited a comment on issue #335: Return early in fetcher if no uris are specified.
URL: https://github.com/apache/mesos/pull/335#issuecomment-496445530
 
 
   @lava 
   Hi. After reading fetcher.cpp more carefully, I find that the reason these tests failed is that we'll call "chown" in FetcherProcess::run. 
   We may move this part ahead to solve this. But it's not elegant enough. 
   
   I also checked MESOS-5218/6843/6217. And I agreed with what Jie Yu said:"The fetcher code is a mess. We should try to clean it up if possible IMO."
   
   I think, FIFO and named pipes used in containerd(between a shim and its container) might be good examples.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services