You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org> on 2006/07/20 02:54:25 UTC

[jira] Created: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
------------------------------------------------------------------------------------

                 Key: MNG-2456
                 URL: http://jira.codehaus.org/browse/MNG-2456
             Project: Maven 2
          Issue Type: Bug
          Components: maven-archiver
    Affects Versions: 2.0.4
            Reporter: Baerrach bonDierne


See related problems MJAR-28 and MASSEMBLY-67.

Summary:

The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
This works fine for released artifacts and non-deployed snapshot.
The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "darbois tomas (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=136485#action_136485 ] 

darboist edited comment on MNG-2456 at 5/28/08 9:49 AM:
-------------------------------------------------------------

Error :p

      was (Author: darboist):
    The problem on Archiver is still existing. maven archiver is currently on version 2.3 so the patch is no longer working for last version of plugins.  (I ve looked at the code and the changes on the code are on part of what the patch is changing).

For example maven-jar-plugin is now using maven archiver 2.3.

Does anyone have an update on the problem ? Or a new patch flly fonctionning with last version of archiver :p


Thanks 
  
> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Barrie Treloar
>            Assignee: Kenney Westerhof
>             Fix For: 2.0.x
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=all ]

Baerrach bonDierne closed MNG-2456.
-----------------------------------

    Resolution: Fixed

In MASSEMBLY-67 John Casey says

The solution here is to use an outputFileNameMapping such as this:

${artifactId}-${baseVersion}.${extension}

Using ${baseVersion} for cases where you want to preserve the -SNAPSHOT naming, the plugin retains the ability to use ${version} for the timestamp-buildnumber naming, which is useful for describing the exact library version included in the assembly.




> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=all ]

Baerrach bonDierne updated MNG-2456:
------------------------------------

    Attachment: MNG-2456-step2-add-test-cases-patch.txt

Test Cases that exercise the problems.
(Unfortunately the patch also includes previous steps)

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Max Bowsher (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=comments#action_74198 ] 
            
Max Bowsher commented on MNG-2456:
----------------------------------

I think this issue should be reopened. It is true that an outputFileNameMapping can provide a workaround, but that's only a workaround, not a fix.

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "darbois tomas (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=136485#action_136485 ] 

darbois tomas commented on MNG-2456:
------------------------------------

The problem on Archiver is still existing. maven archiver is currently on version 2.3 so the patch is no longer working for last version of plugins.  (I ve looked at the code and the changes on the code are on part of what the patch is changing).

For example maven-jar-plugin is now using maven archiver 2.3.

Does anyone have an update on the problem ? Or a new patch flly fonctionning with last version of archiver :p


Thanks 

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Barrie Treloar
>            Assignee: Kenney Westerhof
>             Fix For: 2.0.x
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=comments#action_71722 ] 
            
Baerrach bonDierne commented on MNG-2456:
-----------------------------------------

Oops. Classpath is missing file extension...
Need to update tests and repatch.

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MSHARED-36) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MSHARED-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=148737#action_148737 ] 

jdcasey edited comment on MSHARED-36 at 9/22/08 3:09 PM:
------------------------------------------------------------

I've changed the manifest creation logic to use the timestamp/buildnumber version by default (when the classpathLayoutType is simple - the default value - or repository, which makes it act like a maven repo dir structure). The repo output looks like:

{noformat}
org/codehaus/plexus/plexus-archiver/1.0-alpha-11-SNAPSHOT/plexus-archiver-1.0-alpha-11-20081022.112233-1.jar
{noformat}

You could always specify a custom classpathLayoutType and customClasspathLayout configuration to modify this.

See MSHARED-32 for more info on the custom layout stuff.

      was (Author: jdcasey):
    I've changed the manifest creation logic to use the timestamp/buildnumber version by default (when the classpathLayoutType is simple - the default value - or repository, which makes it act like a maven repo dir structure). The repo output looks like:

{noformat}
org/codehaus/plexus/plexus-archiver/1.0-alpha-11-SNAPSHOT/plexus-archiver-1.0-alpha-11-20081022.112233-1.jar
{noformat}

You could always specify a custom classpathLayoutType and customClasspathLayout configuration to modify this.
  
> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MSHARED-36
>                 URL: http://jira.codehaus.org/browse/MSHARED-36
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-archiver
>            Reporter: Barrie Treloar
>            Assignee: John Casey
>             Fix For: maven-archiver-2.4
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "manuel aldana (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=134770#action_134770 ] 

manuel aldana commented on MNG-2456:
------------------------------------

i got same problem. for the start i workarounded this by setting <uniqueVersion>false</uniqueVersion> in distribution management for snapshots.

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Barrie Treloar
>            Assignee: Kenney Westerhof
>             Fix For: 2.0.x
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Fox updated MNG-2456:
---------------------------

    Fix Version/s:     (was: Reviewed Pending Version Assignment)
                   2.0.x

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Barrie Treloar
>            Assignee: Kenney Westerhof
>             Fix For: 2.0.x
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Matthew McCullough (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104963 ] 

Matthew McCullough edited comment on MNG-2456 at 8/15/07 6:29 PM:
------------------------------------------------------------------

The assembly:assembly behavior that uses the timestamped JAR name causes a disagreement with jar:jar thus resulting in a zip package that can't be executed since the jar names in the manifest are "simple names" and the jars actually delivered in the ZIP assembly are the date-stamped ones.


 was:
The assembly:assembly behavior to also use the timestamped JAR name causes a disagreement with jar:jar thus resulting in a zip package that can't be executed since the jar names in the manifest are "simple names" and the jars actually delivered in the ZIP assembly are the date-stamped ones.

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Barrie Treloar
>            Assignee: Kenney Westerhof
>             Fix For: Reviewed Pending Version Assignment
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Max Bowsher (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=all ]

Max Bowsher updated MNG-2456:
-----------------------------

    Attachment: MNG-2456-maxb.patch

Since I cannot override a core component from a POM, I have made a workaround that fixes the behaviour at the maven-archiver level. I am attaching a patch against maven-archiver-2.2.

My patch is generally along the same fundamental approach as Baerrach's, but with the following differences:
 * aims to fix the problem with minimal changes, instead of including refactoring mixed with the fix.
 * applies the fix to the jar indexing codepath too.
 * tries to avoid hardcoding the details of how to construct artifact filenames.

In that last point, it is only partially successful - I could not work out how to get hold of an appropriate ArtifactRepository object within maven-archiver, so I resorted to making the twin assumptions:
 1. that the existing filepath would contain the correct path, and only the basename need be fixed up.
 2. that a DefaultRepositoryLayout object would give me the correct basename.

In practice this seems to work, even if it is a little ugly.

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=all ]

Baerrach bonDierne updated MNG-2456:
------------------------------------

    Attachment: MNG-2456-step3-fix-bug-patch.txt

Patch to fix the bug and get working unit test
(Unfortunately the patch also includes previous steps)

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=all ]

Baerrach bonDierne updated MNG-2456:
------------------------------------

    Attachment: MNG-2456-step1-refactoring-patch.txt

Attached refactoring patch, with appropriate test cases, that changes Maven Archiver to use Project.getRuntimeArtifacts instead of Project.getRuntimeClasspathElements.


> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-step1-refactoring-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Moved: (MSHARED-36) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHARED-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter moved MNG-2456 to MSHARED-36:
------------------------------------------

    Affects Version/s:     (was: 2.0.4)
        Fix Version/s:     (was: 2.0.x)
          Component/s:     (was: maven-archiver)
                       maven-archiver
                  Key: MSHARED-36  (was: MNG-2456)
              Project: Maven Shared Components  (was: Maven 2)

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MSHARED-36
>                 URL: http://jira.codehaus.org/browse/MSHARED-36
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-archiver
>            Reporter: Barrie Treloar
>            Assignee: Kenney Westerhof
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Baerrach bonDierne (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=all ]

Baerrach bonDierne updated MNG-2456:
------------------------------------

    Attachment: MNG-2456-patch.txt

Patch adds the type of the artifact to the classpath which was incorrectly left off.


> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2456?page=all ]

Brett Porter reopened MNG-2456:
-------------------------------

             

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MSHARED-36) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHARED-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MSHARED-36.
-----------------------------

         Assignee: John Casey  (was: Kenney Westerhof)
       Resolution: Fixed
    Fix Version/s: maven-archiver-2.4

I've changed the manifest creation logic to use the timestamp/buildnumber version by default (when the classpathLayoutType is simple - the default value - or repository, which makes it act like a maven repo dir structure). The repo output looks like:

{noformat}
org/codehaus/plexus/plexus-archiver/1.0-alpha-11-SNAPSHOT/plexus-archiver-1.0-alpha-11-20081022.112233-1.jar
{noformat}

You could always specify a custom classpathLayoutType and customClasspathLayout configuration to modify this.

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MSHARED-36
>                 URL: http://jira.codehaus.org/browse/MSHARED-36
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-archiver
>            Reporter: Barrie Treloar
>            Assignee: John Casey
>             Fix For: maven-archiver-2.4
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Christian Goetze (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=comments#action_84865 ] 
            
Christian Goetze commented on MNG-2456:
---------------------------------------

I would like to see a fix that does not involve adding extra configuration items to the assembly... whatever happened to "convention instead of configuration" - and yes, the onus is on -you- to determine which behaviour should be "standard"...


> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Assigned To: Kenney Westerhof
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126536 ] 

Brian Fox commented on MNG-2456:
--------------------------------

Can someone produce an IT for this?

> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Barrie Treloar
>            Assignee: Kenney Westerhof
>             Fix For: 2.0.x
>
>         Attachments: MNG-2456-maxb.patch, MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-2456) Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots

Posted by "Max Bowsher (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2456?page=comments#action_74484 ] 
            
Max Bowsher commented on MNG-2456:
----------------------------------

I think the true issue is in the core component maven-artifact-manager, in the DefaultArtifactResolver class - which, in the case of a snapshot version, explicitly overrides the artifact's file property from the "version" name to the "baseVersion" name. Search for the line "artifact.setFile( copy );" to find the relevant place in the code. I suggest that that line should simply be deleted, allowing artifact.getName() to remain returning the "version" name.


> Maven Archiver creates incorrect Class-Path entry in Manifest for deployed snapshots
> ------------------------------------------------------------------------------------
>
>                 Key: MNG-2456
>                 URL: http://jira.codehaus.org/browse/MNG-2456
>             Project: Maven 2
>          Issue Type: Bug
>          Components: maven-archiver
>    Affects Versions: 2.0.4
>            Reporter: Baerrach bonDierne
>         Attachments: MNG-2456-patch.txt, MNG-2456-step1-refactoring-patch.txt, MNG-2456-step2-add-test-cases-patch.txt, MNG-2456-step3-fix-bug-patch.txt
>
>
> See related problems MJAR-28 and MASSEMBLY-67.
> Summary:
> The Maven-Archiver uses the file part of the artifact's filename to create the Class-Path entries in the Manifest.
> This works fine for released artifacts and non-deployed snapshot.
> The problem occurs when using a deployed snapshot as the assembly plugin will copy the dependency as ${artifactId}-${version}-timestampedversion.jar and the entry in the Class-Path will be ${artifactId}-${version}-SNAPSHOT
> thus use of java -jar <jarfile> will fail because of the differing names.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira