You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/05/24 06:09:04 UTC

[GitHub] [incubator-shardingsphere] wgy8283335 opened a new issue #2442: '-Long.MAX_VALUE' in assertSetWorkerIdFailureWhenTooMuch() method is not reasonable

wgy8283335 opened a new issue #2442: '-Long.MAX_VALUE' in assertSetWorkerIdFailureWhenTooMuch() method is not reasonable
URL: https://github.com/apache/incubator-shardingsphere/issues/2442
 
 
   Please answer these questions before submitting your issue. Thanks!
   
   ### Which version of ShardingSphere did you use?
   incubator-shardingsphere version is ‘dev’
   
   ### Which project did you use? Sharding-JDBC or Sharding-Proxy?
   incubator-shardingsphere/sharding-core/sharding-core-common
   
   ### Expected behavior
   In SnowflakeShardingKeyGeneratorTest.java, the path is:
   incubator-shardingsphere/sharding-core/sharding-core-common/src/test/java/org/apache/shardingsphere/core/strategy/keygen/SnowflakeShardingKeyGeneratorTest.java.
   In assertSetWorkerIdFailureWhenTooMuch() method.
   The code in line "properties.setProperty("worker.id", String.valueOf(Long.MIN_VALUE));"
   
   ### Actual behavior
   In the method assertSetWorkerIdFailureWhenTooMuch() of SnowflakeShardingKeyGeneratorTest.java
   The code in line "properties.setProperty("worker.id", String.valueOf(-Long.MAX_VALUE));"
   
   ### Reason analyze (If you can)
   I think using Long.MIN_VALUE is more reasonable than -Long.MAX_VALUE.
   
   ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
   
   ### Example codes for reproduce this issue (such as a github link).
   https://github.com/apache/incubator-shardingsphere/blob/dev/sharding-core/sharding-core-common/src/test/java/org/apache/shardingsphere/core/strategy/keygen/SnowflakeShardingKeyGeneratorTest.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services