You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2008/02/11 19:21:54 UTC
DO NOT REPLY [Bug 44393] New: - Wrong fo.Constant values used for break class
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44393>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44393
Summary: Wrong fo.Constant values used for break class
Product: Fop
Version: 1.0dev
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: page-master/layout
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: vincent.hennebert@anyware-tech.com
In fo.layoutmgr.PageBreaker references are made to Constants.EN_ALL or
Constants.EN_NONE whereas the only authorized values for break classes are
EN_AUTO, EN_COLUMN, EN_PAGE, EN_EVEN_PAGE and EN_ODD_PAGE.
As a consequence the region-body_column-count_bug37468 testcase no longer passes
due to the latest changes in the table code.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 44393] - Wrong fo.Constant values used for break class
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44393>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44393
jeremias@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jeremias@apache.org 2008-02-12 00:30 -------
This is not a question if these values are "authorized". Of course, EN_ALL and
EN_NONE are illegal on the break-before/after properties but if we choose to use
them internally, it's our choice. The comments where these are used should make
clear why they are there. Span changes are break conditions for FOP and need to
be handled accordingly. Your change caused something else which doesn't have
anything to do with EN_ALL/EN_NONE. You switched from a (perhaps somewhat
suboptimal) -1 value to generating EN_AUTO for normal breaks in table layout
which caused the PageBreaker to react wrongly. I've added the necessary check to
handle the new case, too.
http://svn.apache.org/viewvc?rev=620723&view=rev
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 44393] - Wrong fo.Constant values used for break class
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44393>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44393
vincent.hennebert@anyware-tech.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
------- Additional Comments From vincent.hennebert@anyware-tech.com 2008-02-12 02:22 -------
Still, I understand your point but there is an inconsistent use of constants
IMO. There seems to be a confusion between the break class (auto, column,
page...) and the next part where the content should start (any, none (??),
column, page...).
The handleBreakTrait method expects a break class for its breakVal parameter
(according to its javadoc) and actually treats it as a "nextSequenceStartsOn"
value. In AbstractBreaker.getNextBlockList en_auto doesn't appear in the switch
block for the break class, so there is likely to be a problem in certain situations.
Re-opening the bug as a remainder that this area may need to be revised, and I
don't have time to look into it now.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 44393] - Wrong fo.Constant values used for break class
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44393>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44393
------- Additional Comments From jeremias@apache.org 2008-02-12 02:49 -------
When a span change happens, the code will never run through
AbstractBreaker.getNextBlockList()'s forced break check. The switch statement
will only ever get enum constants from the break properties. FlowLM handles span
changes much earlier.
http://svn.apache.org/viewvc?rev=620750&view=rev
I still don't see a problem.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.