You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/10 18:16:38 UTC

[GitHub] [kafka] dajac commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

dajac commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468090360



##########
File path: clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java
##########
@@ -74,7 +77,9 @@ public RequestAndSize parseRequest(ByteBuffer buffer) {
                         ", apiVersion: " + header.apiVersion() +
                         ", connectionId: " + connectionId +
                         ", listenerName: " + listenerName +
-                        ", principal: " + principal, ex);
+                        ", principal: " + principal +
+                        ", initial principal: " + initialPrincipalName() +
+                        ", initial client id: " + header.initialClientId(), ex);

Review comment:
       nit: Could we use came case like the others?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org