You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/10 11:03:28 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #3842: Disallow non-empty timezone for CSV reader (#3841)

tustvold opened a new pull request, #3842:
URL: https://github.com/apache/arrow-rs/pull/3842

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #3841
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   This is a temporary "fix" for #3841 pending a more holisitic rework of the parser interface to properly support timezones #1936
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #3842: Disallow non-empty timezone for CSV reader (#3841)

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3842:
URL: https://github.com/apache/arrow-rs/pull/3842#issuecomment-1473910006

   The only thing I think this PR needs is a test -- otherwise 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #3842: Disallow non-empty timezone for CSV reader (#3841)

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3842:
URL: https://github.com/apache/arrow-rs/pull/3842#issuecomment-1480085388

   > Is this PR superceded by https://github.com/apache/arrow-rs/pull/3908 ?
   
   Yes, sorry, meant to close


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #3842: Disallow non-empty timezone for CSV reader (#3841)

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3842:
URL: https://github.com/apache/arrow-rs/pull/3842#issuecomment-1480072727

   Is this PR superceded by  https://github.com/apache/arrow-rs/pull/3908 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed pull request #3842: Disallow non-empty timezone for CSV reader (#3841)

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #3842: Disallow non-empty timezone for CSV reader (#3841)
URL: https://github.com/apache/arrow-rs/pull/3842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org