You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Ian Boston (JIRA)" <ji...@apache.org> on 2010/05/24 11:44:24 UTC
[jira] Created: (SLING-1528) Format of GetAclServlet has changed
Format of GetAclServlet has changed
-----------------------------------
Key: SLING-1528
URL: https://issues.apache.org/jira/browse/SLING-1528
Project: Sling
Issue Type: Bug
Components: JCR
Affects Versions: JCR Jackrabbit Access Manager 2.0.6
Reporter: Ian Boston
Fix For: JCR Jackrabbit Access Manager 2.0.6
as per http://markmail.org/thread/7niaxhzxhxv4a2lo
"
Hi,
I am not certain if this was intentional but the format of GetAclServlet was
changed by [1].
Previously the format was a map keyed by principalid, now its an array
containing objects.
I can understand that an array maintains the order of the ACE's in the ACL which
is required by parts of SLING-1458, however its not backwards compatible and
breaks all existing clients that were expecting a map. Since that might be quite
a lot of code, embedded in Client side Javascript apps and server side http
clients, wouldn't it be better to provide keep the format and add a sequence
number to the map objects? , eg
Old format:
{"user1-1274468817" : {"granted":["jcr:read"]}}
New format
[{"principal":"user1-1274468817","granted":["jcr:read"]}]
Suggested new format
{"user1-1274468817" : {"granted":["jcr:read"], "sequence": 0}}
I know the suggested new format is not as natural, however it won't require all
clients to recode.
If we really do want to migrate to an array, then a new selector might be the
way.
eg ..../node.aclarray.json
WDYT ?
Ian
1 http://svn.apache.org/viewvc?view=revision&revision=927532
"
After leaving this for a few days, there appears to be no objection to changing the format back to the original with an additional sequence property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-1528) Format of GetAclServlet has changed
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston reassigned SLING-1528:
---------------------------------
Assignee: Ian Boston
> Format of GetAclServlet has changed
> -----------------------------------
>
> Key: SLING-1528
> URL: https://issues.apache.org/jira/browse/SLING-1528
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Jackrabbit Access Manager 2.0.6
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: JCR Jackrabbit Access Manager 2.0.6
>
>
> as per http://markmail.org/thread/7niaxhzxhxv4a2lo
> "
> Hi,
> I am not certain if this was intentional but the format of GetAclServlet was
> changed by [1].
> Previously the format was a map keyed by principalid, now its an array
> containing objects.
> I can understand that an array maintains the order of the ACE's in the ACL which
> is required by parts of SLING-1458, however its not backwards compatible and
> breaks all existing clients that were expecting a map. Since that might be quite
> a lot of code, embedded in Client side Javascript apps and server side http
> clients, wouldn't it be better to provide keep the format and add a sequence
> number to the map objects? , eg
> Old format:
> {"user1-1274468817" : {"granted":["jcr:read"]}}
> New format
> [{"principal":"user1-1274468817","granted":["jcr:read"]}]
> Suggested new format
> {"user1-1274468817" : {"granted":["jcr:read"], "sequence": 0}}
> I know the suggested new format is not as natural, however it won't require all
> clients to recode.
> If we really do want to migrate to an array, then a new selector might be the
> way.
> eg ..../node.aclarray.json
> WDYT ?
> Ian
> 1 http://svn.apache.org/viewvc?view=revision&revision=927532
> "
> After leaving this for a few days, there appears to be no objection to changing the format back to the original with an additional sequence property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1528) Format of GetAclServlet has changed
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston resolved SLING-1528.
-------------------------------
Resolution: Fixed
Fixed,
as per discussion, the format is back to a json map, with a new property "order" added to each object to reflect its order in the ACL. The Integration tests have been adjusted to work with the old format.
> Format of GetAclServlet has changed
> -----------------------------------
>
> Key: SLING-1528
> URL: https://issues.apache.org/jira/browse/SLING-1528
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Jackrabbit Access Manager 2.0.6
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: JCR Jackrabbit Access Manager 2.0.6
>
>
> as per http://markmail.org/thread/7niaxhzxhxv4a2lo
> "
> Hi,
> I am not certain if this was intentional but the format of GetAclServlet was
> changed by [1].
> Previously the format was a map keyed by principalid, now its an array
> containing objects.
> I can understand that an array maintains the order of the ACE's in the ACL which
> is required by parts of SLING-1458, however its not backwards compatible and
> breaks all existing clients that were expecting a map. Since that might be quite
> a lot of code, embedded in Client side Javascript apps and server side http
> clients, wouldn't it be better to provide keep the format and add a sequence
> number to the map objects? , eg
> Old format:
> {"user1-1274468817" : {"granted":["jcr:read"]}}
> New format
> [{"principal":"user1-1274468817","granted":["jcr:read"]}]
> Suggested new format
> {"user1-1274468817" : {"granted":["jcr:read"], "sequence": 0}}
> I know the suggested new format is not as natural, however it won't require all
> clients to recode.
> If we really do want to migrate to an array, then a new selector might be the
> way.
> eg ..../node.aclarray.json
> WDYT ?
> Ian
> 1 http://svn.apache.org/viewvc?view=revision&revision=927532
> "
> After leaving this for a few days, there appears to be no objection to changing the format back to the original with an additional sequence property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1528) Format of GetAclServlet has changed
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson closed SLING-1528.
---------------------------------
> Format of GetAclServlet has changed
> -----------------------------------
>
> Key: SLING-1528
> URL: https://issues.apache.org/jira/browse/SLING-1528
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Jackrabbit Access Manager 2.1.0
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: JCR Jackrabbit Access Manager 2.1.0
>
>
> as per http://markmail.org/thread/7niaxhzxhxv4a2lo
> "
> Hi,
> I am not certain if this was intentional but the format of GetAclServlet was
> changed by [1].
> Previously the format was a map keyed by principalid, now its an array
> containing objects.
> I can understand that an array maintains the order of the ACE's in the ACL which
> is required by parts of SLING-1458, however its not backwards compatible and
> breaks all existing clients that were expecting a map. Since that might be quite
> a lot of code, embedded in Client side Javascript apps and server side http
> clients, wouldn't it be better to provide keep the format and add a sequence
> number to the map objects? , eg
> Old format:
> {"user1-1274468817" : {"granted":["jcr:read"]}}
> New format
> [{"principal":"user1-1274468817","granted":["jcr:read"]}]
> Suggested new format
> {"user1-1274468817" : {"granted":["jcr:read"], "sequence": 0}}
> I know the suggested new format is not as natural, however it won't require all
> clients to recode.
> If we really do want to migrate to an array, then a new selector might be the
> way.
> eg ..../node.aclarray.json
> WDYT ?
> Ian
> 1 http://svn.apache.org/viewvc?view=revision&revision=927532
> "
> After leaving this for a few days, there appears to be no objection to changing the format back to the original with an additional sequence property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.