You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/12/14 01:19:46 UTC
[GitHub] sijie commented on a change in pull request #3190: [Pulsar-Flink]
Add Batch Sink Scala Examples Documentation
sijie commented on a change in pull request #3190: [Pulsar-Flink] Add Batch Sink Scala Examples Documentation
URL: https://github.com/apache/pulsar/pull/3190#discussion_r241618517
##########
File path: pulsar-flink/src/test/scala/org/apache/flink/batch/connectors/pulsar/example/README.md
##########
@@ -0,0 +1,262 @@
+The Flink Batch Sink for Pulsar is a custom sink that enables Apache [Flink](https://flink.apache.org/) to write [DataSet](https://ci.apache.org/projects/flink/flink-docs-stable/dev/batch/index.html) to Pulsar.
Review comment:
Can you move the examples to `examples` module? e.g. https://github.com/apache/pulsar/tree/master/examples/flink-consumer-source
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services