You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2022/04/08 14:49:48 UTC

Automating to get latest versions of js scripts with npm?

Hi,

Currently we load specific versions of js scripts (dependencies) with npm (see package.json)

npm has a "latest" option that allows to automatically load the latest versions of a js script.

We had only 3 js scripts versions that are not the latest. I changed all to load latest versions.

After checking things seem to work.

Does somebody see a problem with committing this change?

It should be transparent for users and if a committer see a change he can commit.

Jacques

Re: Automating to get latest versions of js scripts with npm?

Posted by Jacques Le Roux <ja...@les7arts.com>.

I have created OFBIZ-12596 for that

Le 09/04/2022 à 09:03, Jacques Le Roux a écrit :
> Hi Michael,
>
> Fair enough, but we still need to keep those files up to date. For Gradle dependencies we (I at least) use
>
>    <<gradlew -PenableDependencyUpdates dependencyUpdates -Drevision=release>> (see OFBIZ-10213)
>
> The same can be done using "npx npm-check-updates" in themes\common-theme\webapp\common-theme\js
>
> I'll create an OFBIZ-10213 similar umbrella issue for npm and package.json
>
> Thanks
>
> Jacques
>
> Le 08/04/2022 à 17:35, Michael Brohl a écrit :
>> Hi Jacques,
>>
>> the drawback of using latest is that things can break all of a sudden.
>>
>> I would be in favor of using specified versions for ALL js libraries like we do it for the Java libraries in build.gradle.
>>
>> Updating the JS libraries should be done explicitly together with necessary tests.
>>
>> Best regards,
>>
>> Michael Brohl
>>
>> ecomify GmbH - www.ecomify.de
>>
>> Am 08.04.22 um 16:49 schrieb Jacques Le Roux:
>>> Hi,
>>>
>>> Currently we load specific versions of js scripts (dependencies) with npm (see package.json)
>>>
>>> npm has a "latest" option that allows to automatically load the latest versions of a js script.
>>>
>>> We had only 3 js scripts versions that are not the latest. I changed all to load latest versions.
>>>
>>> After checking things seem to work.
>>>
>>> Does somebody see a problem with committing this change?
>>>
>>> It should be transparent for users and if a committer see a change he can commit.
>>>
>>> Jacques
>>>

Re: Automating to get latest versions of js scripts with npm?

Posted by Jacques Le Roux <ja...@les7arts.com>.

Hi Michael,

Fair enough, but we still need to keep those files up to date. For Gradle dependencies we (I at least) use

    <<gradlew -PenableDependencyUpdates dependencyUpdates -Drevision=release>> (see OFBIZ-10213)

The same can be done using "npx npm-check-updates" in themes\common-theme\webapp\common-theme\js

I'll create an OFBIZ-10213 similar umbrella issue for npm and package.json

Thanks

Jacques

Le 08/04/2022 à 17:35, Michael Brohl a écrit :
> Hi Jacques,
>
> the drawback of using latest is that things can break all of a sudden.
>
> I would be in favor of using specified versions for ALL js libraries like we do it for the Java libraries in build.gradle.
>
> Updating the JS libraries should be done explicitly together with necessary tests.
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
> Am 08.04.22 um 16:49 schrieb Jacques Le Roux:
>> Hi,
>>
>> Currently we load specific versions of js scripts (dependencies) with npm (see package.json)
>>
>> npm has a "latest" option that allows to automatically load the latest versions of a js script.
>>
>> We had only 3 js scripts versions that are not the latest. I changed all to load latest versions.
>>
>> After checking things seem to work.
>>
>> Does somebody see a problem with committing this change?
>>
>> It should be transparent for users and if a committer see a change he can commit.
>>
>> Jacques
>>

Re: Automating to get latest versions of js scripts with npm?

Posted by Michael Brohl <mi...@ecomify.de>.

Hi Jacques,

the drawback of using latest is that things can break all of a sudden.

I would be in favor of using specified versions for ALL js libraries 
like we do it for the Java libraries in build.gradle.

Updating the JS libraries should be done explicitly together with 
necessary tests.

Best regards,

Michael Brohl

ecomify GmbH - www.ecomify.de

Am 08.04.22 um 16:49 schrieb Jacques Le Roux:
> Hi,
>
> Currently we load specific versions of js scripts (dependencies) with 
> npm (see package.json)
>
> npm has a "latest" option that allows to automatically load the latest 
> versions of a js script.
>
> We had only 3 js scripts versions that are not the latest. I changed 
> all to load latest versions.
>
> After checking things seem to work.
>
> Does somebody see a problem with committing this change?
>
> It should be transparent for users and if a committer see a change he 
> can commit.
>
> Jacques
>