You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2015/02/23 22:18:39 UTC

Re: Review Request 31315: Wait for status update to be processed before getting master metrics

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31315/
-----------------------------------------------------------

(Updated Feb. 23, 2015, 1:18 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

updated title/description. no functional change.


Summary (updated)
-----------------

Wait for status update to be processed before getting master metrics


Bugs: MESOS-2366
    https://issues.apache.org/jira/browse/MESOS-2366


Repository: mesos


Description (updated)
-------

Wait for status update to be processed before getting master metrics


Diffs
-----

  src/tests/master_slave_reconciliation_tests.cpp 230f5293f4906e09eb55db128df4a19b1e308428 

Diff: https://reviews.apache.org/r/31315/diff/


Testing
-------

300 repeats without failure of the test under a debugger.


Thanks,

Dominic Hamon


Re: Review Request 31315: Wait for status update to be processed before getting master metrics

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31315/#review73747
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Feb. 23, 2015, 9:59 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31315/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 9:59 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2366
>     https://issues.apache.org/jira/browse/MESOS-2366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Wait for status update to be processed before getting master metrics
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp 230f5293f4906e09eb55db128df4a19b1e308428 
> 
> Diff: https://reviews.apache.org/r/31315/diff/
> 
> 
> Testing
> -------
> 
> 300 repeats without failure of the test under a debugger.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 31315: Wait for status update to be processed before getting master metrics

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31315/#review73734
-----------------------------------------------------------


Patch looks great!

Reviews applied: [31315]

All tests passed.

- Mesos ReviewBot


On Feb. 23, 2015, 9:59 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31315/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 9:59 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2366
>     https://issues.apache.org/jira/browse/MESOS-2366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Wait for status update to be processed before getting master metrics
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp 230f5293f4906e09eb55db128df4a19b1e308428 
> 
> Diff: https://reviews.apache.org/r/31315/diff/
> 
> 
> Testing
> -------
> 
> 300 repeats without failure of the test under a debugger.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 31315: Wait for status update to be processed before getting master metrics

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31315/
-----------------------------------------------------------

(Updated Feb. 23, 2015, 1:59 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-2366
    https://issues.apache.org/jira/browse/MESOS-2366


Repository: mesos


Description
-------

Wait for status update to be processed before getting master metrics


Diffs (updated)
-----

  src/tests/master_slave_reconciliation_tests.cpp 230f5293f4906e09eb55db128df4a19b1e308428 

Diff: https://reviews.apache.org/r/31315/diff/


Testing
-------

300 repeats without failure of the test under a debugger.


Thanks,

Dominic Hamon