[GitHub] [pinot] dianaarnos commented on a change in pull request #7997: Add Ingress to Broker and Controller helm charts

[GitBox <gi...@apache.org>]

dianaarnos commented on a change in pull request #7997:
URL: https://github.com/apache/pinot/pull/7997#discussion_r800652169



##########
File path: kubernetes/helm/pinot/templates/controller/ingress.yaml
##########
@@ -0,0 +1,30 @@
+{{- if .Values.controller.ingress.enabled -}}
+{{- $ingressPath := .Values.controller.ingress.path -}}
+{{- $serviceName := include "pinot.controller.fullname" . -}}
+{{- $servicePort := .Values.controller.service.port -}}
+apiVersion: extensions/v1beta1

Review comment:
       @xiangfu0 I added the sections `.Values.controller.ingress.v1beta1` and `.Values.controller.ingress.v1`.
   
   Let me know if that addresses your point.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org