You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/22 10:22:35 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request #5758: fix for #5743
jingshanglu opened a new pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758
Fixes #5743 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #5758: fix for #5743
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on a change in pull request #5758: fix for #5743
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758#discussion_r429394835
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/PostgreSQLKeyword.g4
##########
@@ -587,10 +587,6 @@ TSQUERY
: T S Q U E R Y
;
-UUID
Review comment:
UUID is a key word for data tyep in PostgreSQL. https://www.postgresql.org/docs/9.1/datatype-uuid.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #5758: fix for #5743
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758#issuecomment-632654745
## Pull Request Test Coverage Report for [Build 12045](https://coveralls.io/builds/31006297)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.053%**
---
| Totals | [](https://coveralls.io/builds/31006297) |
| :-- | --: |
| Change from base [Build 11979](https://coveralls.io/builds/30942184): | 0.0% |
| Covered Lines: | 11673 |
| Relevant Lines: | 20460 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #5758: fix for #5743
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758#discussion_r429723516
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/PostgreSQLKeyword.g4
##########
@@ -587,10 +587,6 @@ TSQUERY
: T S Q U E R Y
;
-UUID
Review comment:
There is no uuid keyword in the source code.
https://github.com/postgres/postgres/blob/REL_12_STABLE/src/include/parser/kwlist.h
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5758: fix for #5743
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758#issuecomment-632653023
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=h1) Report
> Merging [#5758](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=desc) into [dev-4.x](https://codecov.io/gh/apache/shardingsphere/commit/308f09f1fdb78cf650a4a75cf9b5adb88cbcedb2&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-4.x #5758 +/- ##
==========================================
Coverage 53.64% 53.64%
Complexity 387 387
==========================================
Files 1147 1147
Lines 20460 20460
Branches 3725 3725
==========================================
Hits 10975 10975
Misses 8799 8799
Partials 686 686
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=footer). Last update [308f09f...8b42f79](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5758: fix for #5743
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758#issuecomment-632654745
## Pull Request Test Coverage Report for [Build 12016](https://coveralls.io/builds/30968723)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.053%**
---
| Totals | [](https://coveralls.io/builds/30968723) |
| :-- | --: |
| Change from base [Build 11979](https://coveralls.io/builds/30942184): | 0.0% |
| Covered Lines: | 11673 |
| Relevant Lines: | 20460 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5758: fix for #5743
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5758:
URL: https://github.com/apache/shardingsphere/pull/5758#issuecomment-632653023
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=h1) Report
> Merging [#5758](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=desc) into [dev-4.x](https://codecov.io/gh/apache/shardingsphere/commit/308f09f1fdb78cf650a4a75cf9b5adb88cbcedb2&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-4.x #5758 +/- ##
==========================================
Coverage 53.64% 53.64%
Complexity 387 387
==========================================
Files 1147 1147
Lines 20460 20460
Branches 3725 3725
==========================================
Hits 10975 10975
Misses 8799 8799
Partials 686 686
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=footer). Last update [308f09f...d88aa26](https://codecov.io/gh/apache/shardingsphere/pull/5758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org