[GitHub] [calcite] hsyuan commented on a change in pull request #1639: [CALCITE-3576] Remove enumerable convention check in FilterIntoJoinRule

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1639: [CALCITE-3576] Remove enumerable convention check in FilterIntoJoinRule
URL: https://github.com/apache/calcite/pull/1639#discussion_r355841229
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java
 ##########
 @@ -53,28 +52,21 @@
    * will be pushed into the ON clause. */
   public static final Predicate TRUE_PREDICATE = (join, joinType, exp) -> true;
 
-  /** Predicate that returns true if the join is not Enumerable convention,
-   * will be replaced by {@link #TRUE_PREDICATE} once enumerable join supports
-   * non-equi join. */
-  // to be removed before 1.22.0
-  private static final Predicate NOT_ENUMERABLE = (join, joinType, exp) ->
-      join.getConvention() != EnumerableConvention.INSTANCE;
-
   /** Rule that pushes predicates from a Filter into the Join below them. */
   public static final FilterJoinRule FILTER_ON_JOIN =
 
 Review comment:
   I don't mind removing it if you think the backward  compatibility is not a concern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services