You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/01 00:04:54 UTC

[GitHub] [kafka] guozhangwang commented on a change in pull request #8130: MINOR: trivial cleanups, javadoc errors, omitted StateStore tests, etc.

guozhangwang commented on a change in pull request #8130:
URL: https://github.com/apache/kafka/pull/8130#discussion_r497865885



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2419,7 +2419,7 @@ class Log(@volatile private var _dir: File,
 
       // replace old segment with new ones
       info(s"Replacing overflowed segment $segment with split segments $newSegments")
-      replaceSegments(newSegments.toList, List(segment), isRecoveredSwapFile = false)
+      replaceSegments(newSegments.toList, List(segment))

Review comment:
       LGTM, since the method definition also has `isRecoveredSwapFile: Boolean = false` by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org