You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/09/14 13:05:06 UTC
[GitHub] [phoenix] stoty opened a new pull request #882: PHOENIX-5032 add Apache Yetus to Phoenix
stoty opened a new pull request #882:
URL: https://github.com/apache/phoenix/pull/882
also replace findbugs support with spotbugs support in maven build
and get mvn site working, and add all reports to it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #882: PHOENIX-5032 add Apache Yetus to Phoenix
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #882:
URL: https://github.com/apache/phoenix/pull/882#discussion_r490774700
##########
File path: dev/docker/Dockerfile.yetus
##########
@@ -0,0 +1,16 @@
+FROM apache/yetus:0.12.0
+
+#####
+# Update SpotBugs
+#####
+RUN rm -rf /opt/spotbugs \
+ && git clone https://github.com/stoty/spotbugs.git \
+ && cd spotbugs \
+ && git checkout PHOENIX-1161-backport \
Review comment:
The branch name is somewhat misleading, as it's actually a fix for Spotbugs issue 1161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #882: PHOENIX-5032 add Apache Yetus to Phoenix
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #882:
URL: https://github.com/apache/phoenix/pull/882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] chrajeshbabu commented on a change in pull request #882: PHOENIX-5032 add Apache Yetus to Phoenix
Posted by GitBox <gi...@apache.org>.
chrajeshbabu commented on a change in pull request #882:
URL: https://github.com/apache/phoenix/pull/882#discussion_r489582800
##########
File path: dev/docker/Dockerfile.yetus
##########
@@ -0,0 +1,16 @@
+FROM apache/yetus:0.12.0
+
+#####
+# Update SpotBugs
+#####
+RUN rm -rf /opt/spotbugs \
+ && git clone https://github.com/stoty/spotbugs.git \
+ && cd spotbugs \
+ && git checkout PHOENIX-1161-backport \
Review comment:
is this branch also correct?
##########
File path: dev/docker/Dockerfile.yetus
##########
@@ -0,0 +1,16 @@
+FROM apache/yetus:0.12.0
+
+#####
+# Update SpotBugs
+#####
+RUN rm -rf /opt/spotbugs \
+ && git clone https://github.com/stoty/spotbugs.git \
Review comment:
isnt it should be https://github.com/spotbugs/spotbugs.git?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #882: PHOENIX-5032 add Apache Yetus to Phoenix
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #882:
URL: https://github.com/apache/phoenix/pull/882#discussion_r490774324
##########
File path: dev/docker/Dockerfile.yetus
##########
@@ -0,0 +1,16 @@
+FROM apache/yetus:0.12.0
+
+#####
+# Update SpotBugs
+#####
+RUN rm -rf /opt/spotbugs \
+ && git clone https://github.com/stoty/spotbugs.git \
Review comment:
For the record, as we have discussed offline, this branch has a fix for a bug in spotbugs 4.12 that breaks the spotbugs result analysis features used by Yetus.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org