You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/30 15:33:02 UTC
[GitHub] [pulsar] freeznet opened a new pull request #9377: [WIP][fix #9315] Add downloadDirectory support to function k8s runtime
freeznet opened a new pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377
Fixes #9315
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-771680320
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on a change in pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
nlu90 commented on a change in pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#discussion_r569875200
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
##########
@@ -200,7 +204,11 @@
this.pulsarRootDir = pulsarRootDir;
this.configAdminCLI = configAdminCLI;
this.userCodePkgUrl = userCodePkgUrl;
- this.originalCodeFileName = pulsarRootDir + "/" + originalCodeFileName;
+ this.downloadDirectory = this.pulsarRootDir; // for backward comp
+ if (StringUtils.isNotBlank(downloadDirectory)) {
+ this.downloadDirectory = downloadDirectory;
+ }
Review comment:
how about `this.downloadDirectory = StringUtils.isNotBlank(downloadDirectory)?downloadDirectory:this.pulsarRootDir;` to avoid some confusion reading this part of code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-771387296
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-771237046
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-781761845
> @freeznet Could you help push a PR based on branch-2.7?
@codelipenghui I have created a new pr #9619, PTAL, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-772237586
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-770678865
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-781753538
@freeznet Could you help push a PR based on branch-2.7?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-770703402
@nlu90 Can you review this pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-775569935
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-772943244
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-772115053
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-773766379
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-770907448
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-789347939
We have another PR for fixing this issue on branch 2.7. So I will remove the `release/2.7.1` label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-771430207
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-771237046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-773766379
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377#issuecomment-774579014
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9377: [fix #9315] Add downloadDirectory support to function k8s runtime
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9377:
URL: https://github.com/apache/pulsar/pull/9377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org