You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2011/05/12 07:39:47 UTC

[jira] [Created] (PIG-2062) Script silently ended

Script silently ended
---------------------

                 Key: PIG-2062
                 URL: https://issues.apache.org/jira/browse/PIG-2062
             Project: Pig
          Issue Type: Bug
          Components: impl
    Affects Versions: 0.9.0
            Reporter: Daniel Dai
             Fix For: 0.9.0


The following script ended silently without execution.

{code}
a = load '1.txt' as (a0, a1);
b = load '2.txt' as (b0, b1);
all = join a by a0, b by b0;
store all into '1111';
{code}

If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2062) Script silently ended

Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xuefu Zhang updated PIG-2062:
-----------------------------

    Attachment: PIG-2062.patch

> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-2062.patch
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2062) Script silently ended

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033149#comment-13033149 ] 

Daniel Dai commented on PIG-2062:
---------------------------------

Now it throws exception. The error message is:
ERROR 1200: <file 100.pig, line 3, column 0>  mismatched input 'all' expecting EOF
Seems still not obvious. 

Can you give some hint of how to improve error message?

> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-2062.patch
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2062) Script silently ended

Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033145#comment-13033145 ] 

Thejas M Nair commented on PIG-2062:
------------------------------------

+1

> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-2062.patch
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (PIG-2062) Script silently ended

Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xuefu Zhang resolved PIG-2062.
------------------------------

    Resolution: Fixed

Patch is committed to both trunk and 0.9.

> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-2062.patch
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2062) Script silently ended

Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033165#comment-13033165 ] 

Xuefu Zhang commented on PIG-2062:
----------------------------------

Unit test passed. Test-patch run:

     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 12 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.


> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-2062.patch
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2062) Script silently ended

Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033136#comment-13033136 ] 

Xuefu Zhang commented on PIG-2062:
----------------------------------

Related to PIG-2003, which is fixed, but it appears that we need a more general fix.

> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-2062.patch
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (PIG-2062) Script silently ended

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich reassigned PIG-2062:
-----------------------------------

    Assignee: Xuefu Zhang

> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2062) Script silently ended

Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033161#comment-13033161 ] 

Xuefu Zhang commented on PIG-2062:
----------------------------------

Well, while not perfect, but I think it's good enough. If you really want to say something like "'all' is a reserved keyword', then you will need to customize the error message for each keyword, which I don't think worthwhile. We had such discussions before. 

> Script silently ended
> ---------------------
>
>                 Key: PIG-2062
>                 URL: https://issues.apache.org/jira/browse/PIG-2062
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-2062.patch
>
>
> The following script ended silently without execution.
> {code}
> a = load '1.txt' as (a0, a1);
> b = load '2.txt' as (b0, b1);
> all = join a by a0, b by b0;
> store all into '1111';
> {code}
> If change the alias "all", it will run. We need to throw exception saying "all" is a keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira