You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Heinrich Bohne <he...@gmx.at> on 2019/06/15 10:41:02 UTC
[numbers] Migration to JUnit 5 complete
Grimreaper and I finished work on the migration to JUnit 5 in the pull
request https://github.com/apache/commons-numbers/pull/48 , so the pull
request is ready for review.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers][statistics] Migration to JUnit 5 complete
Posted by Gilles Sadowski <gi...@gmail.com>.
Hi.
Le mar. 18 juin 2019 à 18:25, Alex Herbert <al...@gmail.com> a écrit :
>
> On 18/06/2019 12:31, Gilles Sadowski wrote:
> > Hi.
> >
> > Le lun. 17 juin 2019 à 00:03, Heinrich Bohne <he...@gmx.at> a écrit :
> >> I made some additional refinements to the test classes in the
> >> commons-numbers-field module (the one with the parameterized tests). The
> >> compiler was warning about unchecked method calls and raw types, so I
> >> added type parameters where appropriate to rectify these issues.
> >>
> >> On 6/15/19 12:41 PM, Heinrich Bohne wrote:
> >>> Grimreaper and I finished work on the migration to JUnit 5 in the pull
> >>> request https://github.com/apache/commons-numbers/pull/48 , so the pull
> >>> request is ready for review.
> > Is there an associated JIRA report?
> >
> > Gilles
>
> Should a JIRA be created for my recent migration of [statistics] to JUnit 5?
As you wish. It's never a problem to have some more tracking but
there is no hard rule for such tasks: It loosely depends on how many
changes are performed and who does it.
> I tried this in a similar vein to the [numbers] migration and it was
> fairly simple. This is waiting in PR 16 [1].
You have commit access.
The policy at Commons is "Commit-Then-Review".
[Although I find it always nice to propose the important changes
before committing them.]
Best,
Gilles
> Note that the Travis CI build is broken due to use of oraclejdk on the
> Travis xenial platform (See [2]). The PR is fine on openjdk8.
>
> Alex
>
> [1] https://github.com/apache/commons-statistics/pull/16
>
> [2] http://markmail.org/message/n2az5dlhqqherj3y
>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers][statistics] Migration to JUnit 5 complete
Posted by Alex Herbert <al...@gmail.com>.
On 18/06/2019 12:31, Gilles Sadowski wrote:
> Hi.
>
> Le lun. 17 juin 2019 à 00:03, Heinrich Bohne <he...@gmx.at> a écrit :
>> I made some additional refinements to the test classes in the
>> commons-numbers-field module (the one with the parameterized tests). The
>> compiler was warning about unchecked method calls and raw types, so I
>> added type parameters where appropriate to rectify these issues.
>>
>> On 6/15/19 12:41 PM, Heinrich Bohne wrote:
>>> Grimreaper and I finished work on the migration to JUnit 5 in the pull
>>> request https://github.com/apache/commons-numbers/pull/48 , so the pull
>>> request is ready for review.
> Is there an associated JIRA report?
>
> Gilles
Should a JIRA be created for my recent migration of [statistics] to JUnit 5?
I tried this in a similar vein to the [numbers] migration and it was
fairly simple. This is waiting in PR 16 [1].
Note that the Travis CI build is broken due to use of oraclejdk on the
Travis xenial platform (See [2]). The PR is fine on openjdk8.
Alex
[1] https://github.com/apache/commons-statistics/pull/16
[2] http://markmail.org/message/n2az5dlhqqherj3y
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers] Migration to JUnit 5 complete
Posted by Heinrich Bohne <he...@gmx.at>.
Hello,
Not that I'm aware of, so I created one:
https://issues.apache.org/jira/browse/NUMBERS-115. I hope I included the
reference to the pull request the correct way.
On 6/18/19 1:31 PM, Gilles Sadowski wrote:
> Hi.
>
> Le lun. 17 juin 2019 à 00:03, Heinrich Bohne <he...@gmx.at> a écrit :
>> I made some additional refinements to the test classes in the
>> commons-numbers-field module (the one with the parameterized tests). The
>> compiler was warning about unchecked method calls and raw types, so I
>> added type parameters where appropriate to rectify these issues.
>>
>> On 6/15/19 12:41 PM, Heinrich Bohne wrote:
>>> Grimreaper and I finished work on the migration to JUnit 5 in the pull
>>> request https://github.com/apache/commons-numbers/pull/48 , so the pull
>>> request is ready for review.
> Is there an associated JIRA report?
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers] Migration to JUnit 5 complete
Posted by Gilles Sadowski <gi...@gmail.com>.
Hi.
Le lun. 17 juin 2019 à 00:03, Heinrich Bohne <he...@gmx.at> a écrit :
>
> I made some additional refinements to the test classes in the
> commons-numbers-field module (the one with the parameterized tests). The
> compiler was warning about unchecked method calls and raw types, so I
> added type parameters where appropriate to rectify these issues.
>
> On 6/15/19 12:41 PM, Heinrich Bohne wrote:
> > Grimreaper and I finished work on the migration to JUnit 5 in the pull
> > request https://github.com/apache/commons-numbers/pull/48 , so the pull
> > request is ready for review.
Is there an associated JIRA report?
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [numbers] Migration to JUnit 5 complete
Posted by Heinrich Bohne <he...@gmx.at>.
I made some additional refinements to the test classes in the
commons-numbers-field module (the one with the parameterized tests). The
compiler was warning about unchecked method calls and raw types, so I
added type parameters where appropriate to rectify these issues.
On 6/15/19 12:41 PM, Heinrich Bohne wrote:
> Grimreaper and I finished work on the migration to JUnit 5 in the pull
> request https://github.com/apache/commons-numbers/pull/48 , so the pull
> request is ready for review.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org