You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/16 10:01:12 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1995: arch: Add custom arch chip build support
xiaoxiang781216 commented on a change in pull request #1995:
URL: https://github.com/apache/incubator-nuttx/pull/1995#discussion_r506246469
##########
File path: tools/Config.mk
##########
@@ -135,6 +135,28 @@ else
DELIM ?= $(strip /)
endif
+# Process chip-specific directories
+
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM),y)
+ CUSTOM_CHIP_DIR = $(patsubst "%",%,$(CONFIG_ARCH_CHIP_CUSTOM_DIR))
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM_DIR_RELPATH),y)
+ CHIP_DIR ?= $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
+else
+ CHIP_DIR ?= $(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
+endif
+ CUSTOM_CHIP_KCONFIG = $(if $(wildcard $(CUSTOM_CHIP_KPATH)),y,)
+else
+ CHIP_DIR ?= $(TOPDIR)$(DELIM)arch$(DELIM)$(CONFIG_ARCH)$(DELIM)src$(DELIM)$(CONFIG_ARCH_CHIP)
+endif
+
+ifeq ($(CUSTOM_CHIP_KCONFIG),y)
+ CHIP_KCONFIG = $(CUSTOM_CHIP_KPATH)
+else
+ CHIP_KCONFIG = $(TOPDIR)$(DELIM)arch$(DELIM)dummy$(DELIM)dummy_kconfig
Review comment:
move to after line 151
##########
File path: tools/Config.mk
##########
@@ -135,6 +135,28 @@ else
DELIM ?= $(strip /)
endif
+# Process chip-specific directories
+
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM),y)
+ CUSTOM_CHIP_DIR = $(patsubst "%",%,$(CONFIG_ARCH_CHIP_CUSTOM_DIR))
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM_DIR_RELPATH),y)
+ CHIP_DIR ?= $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
+else
+ CHIP_DIR ?= $(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
Review comment:
change to CHIP_KCONFIG
##########
File path: tools/Config.mk
##########
@@ -135,6 +135,28 @@ else
DELIM ?= $(strip /)
endif
+# Process chip-specific directories
+
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM),y)
+ CUSTOM_CHIP_DIR = $(patsubst "%",%,$(CONFIG_ARCH_CHIP_CUSTOM_DIR))
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM_DIR_RELPATH),y)
+ CHIP_DIR ?= $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
Review comment:
change to CHIP_KCONFIG
##########
File path: tools/Config.mk
##########
@@ -135,6 +135,28 @@ else
DELIM ?= $(strip /)
endif
+# Process chip-specific directories
+
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM),y)
+ CUSTOM_CHIP_DIR = $(patsubst "%",%,$(CONFIG_ARCH_CHIP_CUSTOM_DIR))
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM_DIR_RELPATH),y)
+ CHIP_DIR ?= $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
+else
+ CHIP_DIR ?= $(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
+endif
+ CUSTOM_CHIP_KCONFIG = $(if $(wildcard $(CUSTOM_CHIP_KPATH)),y,)
Review comment:
remove
##########
File path: tools/Config.mk
##########
@@ -135,6 +135,28 @@ else
DELIM ?= $(strip /)
endif
+# Process chip-specific directories
+
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM),y)
+ CUSTOM_CHIP_DIR = $(patsubst "%",%,$(CONFIG_ARCH_CHIP_CUSTOM_DIR))
+ifeq ($(CONFIG_ARCH_CHIP_CUSTOM_DIR_RELPATH),y)
+ CHIP_DIR ?= $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(TOPDIR)$(DELIM)$(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
+else
+ CHIP_DIR ?= $(CUSTOM_CHIP_DIR)
+ CUSTOM_CHIP_KPATH = $(CUSTOM_CHIP_DIR)$(DELIM)Kconfig
+endif
+ CUSTOM_CHIP_KCONFIG = $(if $(wildcard $(CUSTOM_CHIP_KPATH)),y,)
+else
+ CHIP_DIR ?= $(TOPDIR)$(DELIM)arch$(DELIM)$(CONFIG_ARCH)$(DELIM)src$(DELIM)$(CONFIG_ARCH_CHIP)
+endif
+
+ifeq ($(CUSTOM_CHIP_KCONFIG),y)
+ CHIP_KCONFIG = $(CUSTOM_CHIP_KPATH)
Review comment:
remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org