You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by fg...@apache.org on 2006/01/22 09:54:29 UTC
svn commit: r371241 -
/maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
Author: fgiust
Date: Sun Jan 22 00:54:26 2006
New Revision: 371241
URL: http://svn.apache.org/viewcvs?rev=371241&view=rev
Log:
MCHECKSTYLE-31 documentation issue, pom snippet invalid
Modified:
maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt?rev=371241&r1=371240&r2=371241&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt Sun Jan 22 00:54:26 2006
@@ -70,17 +70,16 @@
<configLocation>whizbang/checkstyle.xml</configLocation>
<headerLocation>whizbang/LICENSE.txt</headerLocation>
</configuration>
- <dependencies>
- <dependency>
- <groupId>com.example.whizbang</groupId>
- <artifactId>build-tools</artifactId>
- <version>1.0</version>
- </dependency>
- </dependencies>
</plugin>
</plugins>
</reporting>
-
+ <dependencies>
+ <dependency>
+ <groupId>com.example.whizbang</groupId>
+ <artifactId>build-tools</artifactId>
+ <version>1.0</version>
+ </dependency>
+ </dependencies>
<modules>
<module>build-tools</module>
<module>core</module>
@@ -99,5 +98,3 @@
-------------------
Every sub project will use the same checkstyle setup and configuration.
-
-
Re: svn commit: r371241 - /maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
Posted by Brett Porter <br...@apache.org>.
Fabrizio Giustina wrote:
> mh, you are right: this works but the "build-tools" dependency will
> end up as an (unwanted) project dependency... anyway, a plugin-level
> dependency doesn't work and it's not valid according to the xsd.
>
> I see this note in Brett commit:
> "don't recommend using extensions, they are resolved too early and put
> into the main classloader which is bound to cause pain. If it doesn't
> work as a plugin dependency, we should fix that."
>
> I'll rollback my commit in the meanwhile, trying to figure out a
> working solution. Brett, could you give us some more light on
> plugin-level dependencies?
...
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<dependencies>
<dependency>
<groupId>com.mycompany</groupId>
<artifactId>build-tools</artifactId>
<version>1.0-SNAPSHOT</version>
</dependency>
</dependencies>
</plugin>
...
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r371241 - /maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
Posted by Fabrizio Giustina <fg...@apache.org>.
On 1/22/06, Vincent Massol <vm...@pivolis.com> wrote:
> Is this correct?
>
> What is the compile scope of build-tools? It seems it will be a "compile"
> scope. Brett put the dependency in the plugin because the build-tools dep is
> actually related only to the plugin and shouldn't be part of the normal
> project dependencies.
mh, you are right: this works but the "build-tools" dependency will
end up as an (unwanted) project dependency... anyway, a plugin-level
dependency doesn't work and it's not valid according to the xsd.
I see this note in Brett commit:
"don't recommend using extensions, they are resolved too early and put
into the main classloader which is bound to cause pain. If it doesn't
work as a plugin dependency, we should fix that."
I'll rollback my commit in the meanwhile, trying to figure out a
working solution. Brett, could you give us some more light on
plugin-level dependencies?
fabrizio
PS. at the moment I am successfully using checkstyle in multi-project
builds by using a flat layout (like the one already suggested for
eclipse users) and a relative location in the master pom like:
<configLocation>../master/checkstyle.xml</configLocation>
Probably not ideal, but easy to setup and working... I was uncertain
if this could be a suggested solution, WDYT?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: svn commit: r371241 - /maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
Posted by Vincent Massol <vm...@pivolis.com>.
Hi Fabrizio,
> -----Original Message-----
> From: fgiust@apache.org [mailto:fgiust@apache.org]
> Sent: dimanche 22 janvier 2006 09:54
> To: commits@maven.apache.org
> Subject: svn commit: r371241 - /maven/plugins/trunk/maven-checkstyle-
> plugin/src/site/apt/tips.apt
[snip]
> MCHECKSTYLE-31 documentation issue, pom snippet invalid
>
> Modified:
> maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
>
> Modified: maven/plugins/trunk/maven-checkstyle-
> plugin/src/site/apt/tips.apt
> URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-checkstyle-
> plugin/src/site/apt/tips.apt?rev=371241&r1=371240&r2=371241&view=diff
> ==========================================================================
> ====
> --- maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt
> (original)
> +++ maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/tips.apt Sun
> Jan 22 00:54:26 2006
> @@ -70,17 +70,16 @@
> <configLocation>whizbang/checkstyle.xml</configLocation>
> <headerLocation>whizbang/LICENSE.txt</headerLocation>
> </configuration>
> - <dependencies>
> - <dependency>
> - <groupId>com.example.whizbang</groupId>
> - <artifactId>build-tools</artifactId>
> - <version>1.0</version>
> - </dependency>
> - </dependencies>
> </plugin>
> </plugins>
> </reporting>
> -
> + <dependencies>
> + <dependency>
> + <groupId>com.example.whizbang</groupId>
> + <artifactId>build-tools</artifactId>
> + <version>1.0</version>
> + </dependency>
> + </dependencies>
Is this correct?
What is the compile scope of build-tools? It seems it will be a "compile"
scope. Brett put the dependency in the plugin because the build-tools dep is
actually related only to the plugin and shouldn't be part of the normal
project dependencies.
Thanks
-Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org