You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by juliuszsompolski <gi...@git.apache.org> on 2018/08/29 12:25:29 UTC
[GitHub] spark pull request #22268: [DOC] Fix comment on SparkPlanGraphEdge
GitHub user juliuszsompolski opened a pull request:
https://github.com/apache/spark/pull/22268
[DOC] Fix comment on SparkPlanGraphEdge
## What changes were proposed in this pull request?
`fromId` is the child, and `toId` is the parent, see line 127 in `buildSparkPlanGraphNode` above.
The edges in Spark UI also go from child to parent.
## How was this patch tested?
Comment change only. Inspected code above. Inspected how the edges in Spark UI look like.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juliuszsompolski/apache-spark sparkplangraphedgedoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22268
----
commit e405f699e51058f8f61a2243862bcd8c6a6013c4
Author: Juliusz Sompolski <ju...@...>
Date: 2018-08-29T12:19:10Z
update doc
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by juliuszsompolski <gi...@git.apache.org>.
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/22268
cc @gatorsmile just a tiny nit...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95416/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22268
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22268
**[Test build #95416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95416/testReport)** for PR 22268 at commit [`e405f69`](https://github.com/apache/spark/commit/e405f699e51058f8f61a2243862bcd8c6a6013c4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2668/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22268
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22268
**[Test build #95416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95416/testReport)** for PR 22268 at commit [`e405f69`](https://github.com/apache/spark/commit/e405f699e51058f8f61a2243862bcd8c6a6013c4).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22268: [DOC] Fix comment on SparkPlanGraphEdge
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22268
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org