[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4346: Adding support for udfs in Selection

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #4346: Adding support for udfs in Selection
URL: https://github.com/apache/incubator-pinot/pull/4346#discussion_r296046550
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/TransformBlockDataFetcher.java
 ##########
 @@ -0,0 +1,340 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.transform;
+
+import java.io.Serializable;
+import org.apache.pinot.common.data.FieldSpec;
+import org.apache.pinot.common.data.FieldSpec.DataType;
+import org.apache.pinot.common.request.transform.TransformExpressionTree;
+import org.apache.pinot.common.utils.BytesUtils;
+import org.apache.pinot.common.utils.primitive.ByteArray;
+import org.apache.pinot.core.common.BlockValSet;
+import org.apache.pinot.core.segment.index.readers.Dictionary;
+
+public class TransformBlockDataFetcher {
+
+
+  private final Fetcher[] _fetchers;
+
+  public TransformBlockDataFetcher(BlockValSet[] blockValSets, Dictionary[] dictionaries,
+      TransformResultMetadata[] expressionResultMetadata) {
+    _fetchers = new Fetcher[blockValSets.length];
+    for (int i = 0; i < blockValSets.length; i++) {
+      _fetchers[i] = createFetcher(blockValSets[i], dictionaries[i],
+          expressionResultMetadata[i]);
+    }
+  }
+
+  public Serializable[] getRow(int docId) {
+    Serializable[] row = new Serializable[_fetchers.length];
+    for (int i = 0; i < _fetchers.length; i++) {
+      row[i] = _fetchers[i].getValue(docId);
+    }
+    return row;
+  }
+
+  Fetcher createFetcher(BlockValSet blockValSet,
+      Dictionary dictionary,
+      TransformResultMetadata expressionResultMetadata) {
+    if (expressionResultMetadata.hasDictionary()) {
+      if (expressionResultMetadata.isSingleValue()) {
+        return new DictionaryBasedSVValueFetcher(dictionary,
+            blockValSet.getDictionaryIdsSV(), expressionResultMetadata.getDataType());
+      } else {
+        switch (expressionResultMetadata.getDataType()) {
+          case INT:
+            return new DictionaryBasedMVIntValueFetcher(dictionary,
+                blockValSet.getDictionaryIdsMV());
+          case LONG:
+            return new DictionaryBasedMVLongValueFetcher(dictionary,
+                blockValSet.getDictionaryIdsMV());
+          case FLOAT:
+            return new DictionaryBasedMVFloatValueFetcher(dictionary,
+                blockValSet.getDictionaryIdsMV());
+          case DOUBLE:
+            return new DictionaryBasedMVDoubleValueFetcher(dictionary,
+                blockValSet.getDictionaryIdsMV());
+          case BOOLEAN:
+          case STRING:
+            return new DictionaryBasedMVStringValueFetcher(dictionary,
+                blockValSet.getDictionaryIdsMV());
+          case BYTES:
+            return new DictionaryBasedMVBytesValueFetcher(dictionary,
+                blockValSet.getDictionaryIdsMV());
+        }
+      }
+    } else {
+      switch (expressionResultMetadata.getDataType()) {
+        case INT:
+          return new SVIntValueFetcher(blockValSet.getIntValuesSV());
+        case LONG:
+          return new SVLongValueFetcher(blockValSet.getLongValuesSV());
+        case FLOAT:
+          return new SVFloatValueFetcher(blockValSet.getFloatValuesSV());
+        case DOUBLE:
+          return new SVDoubleValueFetcher(blockValSet.getDoubleValuesSV());
+        case BOOLEAN:
+        case STRING:
+          return new SVStringValueFetcher(blockValSet.getStringValuesSV());
+        case BYTES:
+          return new SVBytesValueFetcher(blockValSet.getBytesValuesSV());
+      }
+    }
+    throw new UnsupportedOperationException();
+  }
+}
+
+
+interface Fetcher {
 
 Review comment:
   Is there a reason why we cannot use the DataFetcher that already exists?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org