You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Adebski <gi...@git.apache.org> on 2017/07/02 15:32:02 UTC
[GitHub] flink pull request #4244: [docs]Added missing "more" word to programming-mod...
GitHub user Adebski opened a pull request:
https://github.com/apache/flink/pull/4244
[docs]Added missing "more" word to programming-model docs.
Today I was reading about Apache Flink and spotted missing word in the documentation. I didn't create JIRA issue - I assume this kind of "error" qualifies as
> We require all documentation changes to refer to a JIRA issue, except for trivial fixes such as typos.
If not I will create the issue and modify the PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Adebski/flink programming-model-missing-word
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4244
----
commit e8568ee8a24aa204237ec4a784b84dadb93dad7e
Author: adebski <an...@gmail.com>
Date: 2017-07-02T15:28:41Z
[docs]Added missing "more" word to programming-model docs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4244: [docs]Added missing "more" word to programming-model docs...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4244
@Adebski thanks for the fix.
Yes I think this qualifies as a trivial fix and doesn't require a JIRA. For these kind of fixes we usually prefix the commit message with a `[hotfix]`.
LGTM, merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4244: [docs]Added missing "more" word to programming-mod...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4244: [docs]Added missing "more" word to programming-model docs...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4244
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---