You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/13 13:03:29 UTC

[GitHub] [flink] Shawn-Hx opened a new pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Shawn-Hx opened a new pull request #14066:
URL: https://github.com/apache/flink/pull/14066


   
   ## What is the purpose of the change
   
   Change link format from:
   
   `{{ site.baseurl }/... }`
   
   to:
   
   `{% link ... %}`
   
   ## Brief change log
   
   Change all link format in `docs/ops` dir.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   Execute `./build_docs.sh` normally.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman closed pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #14066:
URL: https://github.com/apache/flink/pull/14066


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726763095


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563",
       "triggerID" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565",
       "triggerID" : "726788033",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "65e09b7974530d4542de135f428074dbbd6a9eb4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9651",
       "triggerID" : "65e09b7974530d4542de135f428074dbbd6a9eb4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6d180cae9b82981c786f865ef7d077aff41187fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565) 
   * 65e09b7974530d4542de135f428074dbbd6a9eb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9651) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Shawn-Hx commented on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
Shawn-Hx commented on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-727901041


   Hi, @sjwiesman 
   Could you help to review at your convenience ?
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726763095


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563",
       "triggerID" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565",
       "triggerID" : "726788033",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "65e09b7974530d4542de135f428074dbbd6a9eb4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "65e09b7974530d4542de135f428074dbbd6a9eb4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6d180cae9b82981c786f865ef7d077aff41187fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565) 
   * 65e09b7974530d4542de135f428074dbbd6a9eb4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Shawn-Hx commented on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
Shawn-Hx commented on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726788033


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726763095


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563",
       "triggerID" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565",
       "triggerID" : "726788033",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 6d180cae9b82981c786f865ef7d077aff41187fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Shawn-Hx commented on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
Shawn-Hx commented on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-728140865


   @sjwiesman Thanks for reminder. Have resolved the conflict. PTAL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726763095


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563",
       "triggerID" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565",
       "triggerID" : "726788033",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 6d180cae9b82981c786f865ef7d077aff41187fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9565) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726763095


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563",
       "triggerID" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6d180cae9b82981c786f865ef7d077aff41187fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9563) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-728183693


   Grazi, merging . . . 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726763095


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6d180cae9b82981c786f865ef7d077aff41187fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6d180cae9b82981c786f865ef7d077aff41187fb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-728131797


   @Shawn-Hx Thank you for doing this! Can you please rebase your branch and resolve the conflict? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14066: [FLINK-20144][docs] Change link format in docs/ops dir

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14066:
URL: https://github.com/apache/flink/pull/14066#issuecomment-726754048


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6d180cae9b82981c786f865ef7d077aff41187fb (Fri Nov 13 13:05:36 UTC 2020)
   
   **Warnings:**
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20144).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org