[jira] [Work logged] (GOBBLIN-1616) Make RestApiConnector be able to close the connection finally

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1616?focusedWorklogId=734978&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734978 ]

ASF GitHub Bot logged work on GOBBLIN-1616:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/22 22:03
            Start Date: 01/Mar/22 22:03
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on a change in pull request #3474:
URL: https://github.com/apache/gobblin/pull/3474#discussion_r817177984



##########
File path: gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiConnector.java
##########
@@ -77,6 +82,15 @@ public RestApiConnector(State state) {
         state.getPropAsInt(ConfigurationKeys.SOURCE_CONN_TIMEOUT, ConfigurationKeys.DEFAULT_CONN_TIMEOUT);
   }
 
+  @Override
+  public void close() throws IOException {

Review comment:
       When does this close() get called for Dynamics?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 734978)
    Time Spent: 20m  (was: 10m)

> Make RestApiConnector be able to close the connection finally
> -------------------------------------------------------------
>
>                 Key: GOBBLIN-1616
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1616
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In RestApiConnector, we only consume the HttpEntity but not close the response, which potentially leave the socket as CLOSE_WAIT status and eat up the resources. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)