[GitHub] [incubator-druid] leventov opened a new issue #8756: Prohibit Futures.addCallback(Future, Callback) (i. e. using directExecutor() implicitly) using forbidden-apis

[GitBox <gi...@apache.org>]

leventov opened a new issue #8756: Prohibit Futures.addCallback(Future, Callback) (i. e. using directExecutor() implicitly) using forbidden-apis
URL: https://github.com/apache/incubator-druid/issues/8756
 
 
   [This method is deprecated and removed from later versions of Guava for good reasons.](https://guava.dev/releases/22.0/api/docs/com/google/common/util/concurrent/Futures.html#addCallback-com.google.common.util.concurrent.ListenableFuture-com.google.common.util.concurrent.FutureCallback-) Using this method mindlessly causes problems like #8445.
   
   While Druid is stuck with older Guava, it should prohibit the problematic method proactively using forbidden-apis, forcing specifying an executor explicitly, and actually thinking about which executor should be used.
   
   There are currently 19 usages of this method in Druid production code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org