You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2024/01/17 22:44:21 UTC
[PR] ARTEMIS-4572 upgrade to Apache parent 31 [activemq-artemis]
jbertram opened a new pull request, #4746:
URL: https://github.com/apache/activemq-artemis/pull/4746
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4572 upgrade to Apache parent 31 [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4746:
URL: https://github.com/apache/activemq-artemis/pull/4746#discussion_r1457612687
##########
pom.xml:
##########
@@ -1750,10 +1749,16 @@
<artifactId>jacoco-maven-plugin</artifactId>
<version>${version.org.jacoco.plugin}</version>
</plugin>
+ <plugin>
+ <!-- This is needed until https://issues.apache.org/jira/browse/MSHADE-462 is resolved. Once that is
+ done then we can inherit the version from the Apache parent POM. -->
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>3.4.1</version>
+ </plugin>
Review Comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4572 upgrade to Apache parent 31 [activemq-artemis]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr merged PR #4746:
URL: https://github.com/apache/activemq-artemis/pull/4746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4572 upgrade to Apache parent 31 [activemq-artemis]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #4746:
URL: https://github.com/apache/activemq-artemis/pull/4746#discussion_r1457309493
##########
etc/checkstyle.xml:
##########
@@ -100,14 +100,15 @@ under the License.
<property name="severity" value="ignore"/>
</module>
- <!-- Sevntu checks, http://sevntu-checkstyle.github.io/sevntu.checkstyle/ -->
- <module name="DiamondOperatorForVariableDefinition"/>
<module name="RequiredParameterForAnnotation">
<property name="annotationName" value="Parameterized.Parameters"/>
<property name="requiredParameters" value="name"/>
</module>
<module name="UnnecessarySemicolonInTryWithResources"/>
+ <!-- Sevntu checks, http://sevntu-checkstyle.github.io/sevntu.checkstyle/ -->
+ <module name="DiamondOperatorForVariableDefinition"/>
Review Comment:
The comment seems potentially out of place now since e.g RequiredParameterForAnnotation also looks to be a Sevntu check? Did this need moved?
##########
pom.xml:
##########
@@ -1750,10 +1749,16 @@
<artifactId>jacoco-maven-plugin</artifactId>
<version>${version.org.jacoco.plugin}</version>
</plugin>
+ <plugin>
+ <!-- This is needed until https://issues.apache.org/jira/browse/MSHADE-462 is resolved. Once that is
+ done then we can inherit the version from the Apache parent POM. -->
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>3.4.1</version>
+ </plugin>
Review Comment:
You can just set (i.e override) the property they used in the parent dependencyManagement to the desired version, rather than add the full config and hard-coded version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4572 upgrade to Apache parent 31 [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4746:
URL: https://github.com/apache/activemq-artemis/pull/4746#discussion_r1457617333
##########
etc/checkstyle.xml:
##########
@@ -100,14 +100,15 @@ under the License.
<property name="severity" value="ignore"/>
</module>
- <!-- Sevntu checks, http://sevntu-checkstyle.github.io/sevntu.checkstyle/ -->
- <module name="DiamondOperatorForVariableDefinition"/>
<module name="RequiredParameterForAnnotation">
<property name="annotationName" value="Parameterized.Parameters"/>
<property name="requiredParameters" value="name"/>
</module>
<module name="UnnecessarySemicolonInTryWithResources"/>
+ <!-- Sevntu checks, http://sevntu-checkstyle.github.io/sevntu.checkstyle/ -->
+ <module name="DiamondOperatorForVariableDefinition"/>
Review Comment:
I looked in the Sevntu Git repo for `RequiredParameterForAnnotation` and I couldn't find it, but I see now that I was looking in the wrong place (i.e. `coding` package instead of `annotation`). My goal here was to clarify which specific checks were from Sevntu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org